Feature #10115
Automatically rename blank CSV header columns
Status: | Verified | Start date: | 07/11/2016 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | CSV import | |||
Target version: | Release 2.4.0 | |||
Google Code Legacy ID: | Tested version: | |||
Sponsored: | No | Requires documentation: |
Description
Give them names like "Untitled1", "Untitled2", etc.
History
#2 Updated by Mike Cantelon almost 6 years ago
- Status changed from New to Code Review
- Assignee changed from Mike Cantelon to Nick Wilkinson
PR for code review: https://github.com/artefactual/atom/pull/414
#3 Updated by Nick Wilkinson almost 6 years ago
- Assignee changed from Nick Wilkinson to Mike Gale
Hi Mike, assigning to you for CR.
#4 Updated by Mike Gale almost 6 years ago
- Assignee changed from Mike Gale to Mike Cantelon
Looks good. I suggested maybe breaking out some code into a private helper function, but it's only several lines of code so I'll leave that up to you if you want to do it.
#5 Updated by Mike Cantelon almost 6 years ago
- Assignee changed from Mike Cantelon to Mike Gale
I split the naming of untitled columns into its own method... does this make more sense?
#6 Updated by Mike Gale almost 6 years ago
Sure! is it pushed to the github PR?
#7 Updated by Mike Cantelon almost 6 years ago
Yeah, I pushed it up there.
#8 Updated by Mike Gale almost 6 years ago
- Assignee changed from Mike Gale to Mike Cantelon
Looks good to me
#9 Updated by Mike Cantelon almost 6 years ago
Thanks!
#10 Updated by Mike Cantelon almost 6 years ago
- Status changed from Code Review to QA/Review
- Assignee changed from Mike Cantelon to Nick Wilkinson
#11 Updated by Nick Wilkinson almost 6 years ago
- Status changed from QA/Review to Verified
- Assignee deleted (
Nick Wilkinson)
#12 Updated by Dan Gillean almost 4 years ago
- Target version set to Release 2.4.0