Bug #10278

Adding a second date in the ISAD/DACS etc template removes the first date on save

Added by Dan Gillean almost 4 years ago. Updated almost 3 years ago.

Status:VerifiedStart date:09/06/2016
Priority:HighDue date:
Assignee:Kelly Stewart% Done:

0%

Category:Information objectEstimated time:12.00 hours
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:2.2.1, 2.3, 2.4
Sponsored:No Requires documentation:

Description

  • Create a new description
  • Give it a date of creation 2012 - 2013, save
  • Re-enter edit mode
  • Add a second date: Accumulation, 2014 - 2015. Save
Resulting error
  • The first date is removed upon save
  • Only one date (the second date added) appears
Expected result
  • User can edit a description to add a second date without losing the first date

See also: #7758

Note: initially, work should be done in a separate branch, and nothing should be submitted to qa/2.4.x until the fix is done.


Related issues

Related to Access to Memory (AtoM) - Bug #7758: Date widget in archival description template will not sav... Verified 01/02/2015

History

#1 Updated by Dan Gillean almost 4 years ago

  • Related to Bug #7758: Date widget in archival description template will not save edits to data when new date is also added added

#2 Updated by Dan Gillean almost 4 years ago

  • Subject changed from Adding a second date in the ISAD template removes the first date on save to Adding a second date in the ISAD/DACS etc template removes the first date on save

updated title: also reproduced on the DACS template; not on the RAD template. It seems any template using the ISAD-style dates widget is affected.

#3 Updated by Dan Gillean almost 4 years ago

Note as well that this was first reported in the user forum, here: https://groups.google.com/d/topic/ica-atom-users/1jEqFbJ9JE4/discussion

The user reports that edits to any other field will also have the same effect - I haven't yet tested this, but can confirm that trying to add a second date will definitely cause this problem.

#4 Updated by Nick Wilkinson over 3 years ago

  • Description updated (diff)

#5 Updated by Nick Wilkinson over 3 years ago

  • Estimated time set to 12.00

#6 Updated by Nick Wilkinson over 3 years ago

  • Assignee set to Steve Breker

#7 Updated by Steve Breker over 3 years ago

  • Status changed from New to Code Review
  • Assignee changed from Steve Breker to Nick Wilkinson

I was unable to replicate the original reported issue. Dan looked into it and found that he could not replicate it as described either.

A related issue that he discovered was:

- Create a description with a date, save
- Re-enter edit mode
- Add a new accumulation date AND make edits to the existing creation date. Save
- Result: changes to existing creation date are not saved - reverts to old values.

I have tracked down this issue and corrected it for all description template types. Not that for template types where dates and actors can be updated (MODS, RAD) that the same issue affected saving actors and modifications. This has also been fixed.

PR is here:
https://github.com/artefactual/atom/pull/516

#8 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Mike Cantelon

Hi Mike, assigning to you for CR.

#9 Updated by Mike Cantelon over 3 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Mike Cantelon to Steve Breker

Looks good to me!

#10 Updated by Steve Breker over 3 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Steve Breker to Nick Wilkinson

Merged to qa/2.4.x.

Ready for QA.

#11 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Kelly Stewart

Hi Kelly, assigning to you for QA.

#12 Updated by Dan Gillean over 3 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Kelly Stewart)
  • Target version set to Release 2.4.0

#13 Updated by Steve Breker about 3 years ago

I have cherry-picked this fix for stable/2.3.x. I have verified that the issue reported in comment 7 above was occurring in stable/2.3.x (the Rossi client repo).

Hash for the commit is:
fdda8001dd678958429132ecc82ecca3a439ff2b

#15 Updated by Steve Breker about 3 years ago

  • Status changed from Verified to Feedback
  • Assignee set to José Raddaoui Marín

Code review complete. Looks good.

#16 Updated by José Raddaoui Marín about 3 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

Merged in stable/2.3.x and qa/2.4.x

#17 Updated by Nick Wilkinson about 3 years ago

  • Assignee changed from Nick Wilkinson to Dan Gillean

#18 Updated by Dan Gillean about 3 years ago

  • Assignee deleted (Dan Gillean)

#19 Updated by Kelly Stewart almost 3 years ago

  • Assignee set to Kelly Stewart

#20 Updated by Kelly Stewart almost 3 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF