Bug #10295
"all matching descriptions" link in global search autocomplete drop-down will display JSON
Status: | Verified | Start date: | 09/12/2016 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Search / Browse | |||
Target version: | Release 2.4.0 | |||
Google Code Legacy ID: | Tested version: | 2.3 | ||
Sponsored: | No | Requires documentation: |
Description
First reported in the user forum: https://groups.google.com/d/msg/ica-atom-users/KMtNni8ZjzQ/l6E5dahfCQAJ
Tested internally and reproduced in 2.3.
To reproduce
- Find a common term in your AtoM data that will return more than 3 results (e.g. "correspondence")
- Type the term into the global search box
- In the autocomplete drop-down, the first 3 matching results will appear for descriptions, followed by a link to return "All matching descriptions"
- Click on the "All matching descriptions" link.
Resulting error
- User is returned JSON
Expected result
- User is taken to a search results page limited to results matching the keyword entered
Notes:
A pull request has been submitted here: https://github.com/artefactual/atom/pull/434
Comment from the developer submitting the PR:
"In AtoM 2.3, the search was changed "from search?query=Dalhousie&repos=" to "informationobject/browse?topLod=0&query=Dalhousie&repos=". The autocomplete drop down for "all matching descriptions" was not updated to match the changes. If a user selects it, they will be shown encoded json instead of a valid AtoM search page."
Related issues
History
#1 Updated by Nick Wilkinson over 5 years ago
- Assignee changed from Nick Wilkinson to Steve Breker
#2 Updated by Steve Breker over 5 years ago
Code review complete. Recommended updating the format of commit message to follow standard format.
#3 Updated by Dan Gillean over 5 years ago
Otherwise, code itself looked good, Steve? e.g. do you think we can merge this if the requested changes to the msg are made?
#4 Updated by Steve Breker over 5 years ago
Hi Dan - I have tested the code. Merging into qa/2.4.x should be fine.
Update: Merged.
https://github.com/artefactual/atom/commit/5f83110a92acbfb0af7b58fdfb76f71357a39d0a
#5 Updated by Steve Breker over 5 years ago
- Status changed from New to QA/Review
- Assignee changed from Steve Breker to Dan Gillean
#6 Updated by Dan Gillean over 5 years ago
- Related to Bug #5720: Click "all matching ..." in the search box autocomplete list leads to a browse page without the same results added
#7 Updated by Dan Gillean over 5 years ago
- Related to Bug #7757: Global search autocomplete links to all matching search results do not work for entities other than descriptions added
#8 Updated by Dan Gillean over 5 years ago
- Status changed from QA/Review to Verified
- Assignee changed from Dan Gillean to Steve Breker
- Target version set to Release 2.4.0
Works! Thank you to community contributor Margaret Vail for this fix!
#9 Updated by José Raddaoui Marín over 5 years ago
- Status changed from Verified to In progress
- Assignee changed from Steve Breker to José Raddaoui Marín
There is another "unrelated" bug in those links. If the multi-repository setting is turn off, clicking all matching descriptions leads you to a page without results. This is caused because the parameter "repos=all" is added to those links when no realm check-boxes are included in the search-box drop-down. See:
https://github.com/artefactual/atom/blob/qa/2.4.x/apps/qubit/modules/search/templates/_box.php#L19-L50
https://github.com/artefactual/atom/blob/qa/2.4.x/js/dominion.js#L354-L362
https://github.com/artefactual/atom/blob/qa/2.4.x/apps/qubit/modules/search/templates/autocompleteSuccess.php#L16
#10 Updated by José Raddaoui Marín over 5 years ago
- Status changed from In progress to Code Review
- Assignee changed from José Raddaoui Marín to Steve Breker
Small fix ready for code review: PR 514
#11 Updated by Steve Breker over 5 years ago
CR complete - looks good.
#12 Updated by Steve Breker over 5 years ago
- Status changed from Code Review to Feedback
- Assignee changed from Steve Breker to José Raddaoui Marín
#13 Updated by José Raddaoui Marín over 5 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from José Raddaoui Marín to Dan Gillean
Merged in qa/2.4.x and stable/2.3.x (the two commits)
#14 Updated by Dan Gillean over 5 years ago
- Status changed from QA/Review to Verified
- Assignee deleted (
Dan Gillean)