Bug #10438

Change Digital Object upload to use generic file move routine

Added by Steve Breker almost 5 years ago. Updated over 2 years ago.

Status:In progressStart date:
Priority:LowDue date:
Assignee:Mike Cantelon% Done:

0%

Category:Import/ExportEstimated time:6.00 hours
Target version:-
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Remove duplicated code in modules/digitalobject/actions/uploadAction.class.php by calling Qubit::moveUploadFile() instead.

moveUploadFile() is a static method in Qubit.class.php and is a generic utility to copy an uploaded file into the uploads/tmp folder where it can be accessed after the upload controller completes.

History

#1 Updated by Steve Breker almost 5 years ago

  • Estimated time set to 5.00

#2 Updated by Steve Breker almost 5 years ago

  • Target version set to Release 2.5.0

#3 Updated by Steve Breker almost 5 years ago

  • Estimated time changed from 5.00 to 6.00

#4 Updated by Jesús García Crespo almost 5 years ago

Note that moveUploadFile does not make use of sfValidatedFile, that should be addressed too.

#5 Updated by Nick Wilkinson over 3 years ago

  • Assignee set to Mike Cantelon

#6 Updated by Mike Cantelon almost 3 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#7 Updated by Nick Wilkinson almost 3 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#8 Updated by José Raddaoui Marín almost 3 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

Looks good!

#9 Updated by Mike Cantelon almost 3 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

I guessing QAing this just means verifying that DO uploading still works.

#10 Updated by Mike Cantelon almost 3 years ago

  • Status changed from QA/Review to In progress
  • Assignee changed from Dan Gillean to Mike Cantelon

Just realized I didn't look into the sfValidatedFile issue.

#11 Updated by Mike Cantelon over 2 years ago

  • Target version changed from Release 2.5.0 to Release 2.5.1

#12 Updated by Mike Cantelon over 2 years ago

  • Target version deleted (Release 2.5.1)

Also available in: Atom PDF