Bug #10473

Missing site base URL warning cannot be translated

Added by Jesús García Crespo over 3 years ago. Updated about 3 years ago.

Status:VerifiedStart date:10/25/2016
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:I18N
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:2.3, 2.4
Sponsored:No Requires documentation:

Description

The string literal 'Please configure your site base URL' is not wrapped with the _() i18n helper.

https://github.com/artefactual/atom/blob/a61bd12483bb467dfbe6153c8accb2a417d9948a/apps/qubit/templates/_header.php#L5

Also, the div was identified as "update-check" which is not a good idea. Basic HTML rule: Element IDs should be unique within the entire document. We should create a new CSS class and update _header.php and _updateCheck.php accordingly.

History

#1 Updated by Jesús García Crespo over 3 years ago

  • Description updated (diff)

#2 Updated by Mike Cantelon over 3 years ago

  • Status changed from New to In progress
  • Assignee set to Mike Cantelon

#3 Updated by Mike Cantelon over 3 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#4 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

#5 Updated by Mike Gale over 3 years ago

  • Assignee changed from Mike Gale to Mike Cantelon

looks good

#6 Updated by Mike Cantelon over 3 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

Thanks! Merged and ready for QA.

#7 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Dan Gillean

#8 Updated by Dan Gillean about 3 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

The string is now available in the 2.4 resources in Transifex.

Also available in: Atom PDF