Bug #10729

Regression: import-bulk CLI task is calling each import an error

Added by Dan Gillean over 3 years ago. Updated over 3 years ago.

Status:VerifiedStart date:01/04/2017
Priority:HighDue date:
Assignee:-% Done:

0%

Category:EAD
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Discovered when trying to load a set of demo data I have used on and off since at least 2.2 - so I know these XML files should import. They are included in a zip file attached here. I was performing the import in my Ubuntu 14.04 Vagrant box, and Mike G reproduced it on his local machine, on qa/2.4.x.

  • Unpack the zip file, and put it somewhere accessible. For me that was /vagrant/import-bulk
  • From AtoM's root directory, run: php symonfy import:bulk /vagrant/import-bulk/

Resulting error

Every single record seems to be treated as if the task is looking for a match first, and only creating a new record when no match is found - but it calls this an error. It does this for every record in a hierarchical EAD file. Example output from the console:

Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Conveyance: John Hanlon et al to William Hanlon
Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Mortgage: William Hanlon to the Trust & Loan Co. of Canada
Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Quit claim deed: Daniel Hanlon et al to William Hanlon
Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Mortgage : William Hanlan et al to Simpson Hill
Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Charles Marriott et al to Jane M. Kerr: deed of land situate on Rosedale Road, Toronto
Error (/vagrant/import-bulk/john-honsberger-fonds.xml): Creating a new record: Thomas B. Townsend to Thomas B. Townsend the younger: deed of land

Expected outcome

No errors thrown for record creation during new import - e.g. an import without parameters used.
Default when no options are used is to treat imports as new records.

import-bulk-1.zip (146 KB) Dan Gillean, 01/04/2017 07:45 PM

overly-verbose-bulk-import.png (109 KB) Mike Gale, 01/04/2017 07:53 PM

History

#1 Updated by Mike Gale over 3 years ago

I also got this when running php symfony import:bulk import-bulk (using the folder in the .zip attached here).

#2 Updated by Dan Gillean over 3 years ago

Comment from Steve:

This is static text, from when the console output was only used for errors. See line 151 in lib/task/import/importBulkTask.class.php. Can remove 'Error'.

#3 Updated by Steve Breker over 3 years ago

  • Assignee set to Steve Breker

#4 Updated by Steve Breker over 3 years ago

  • Status changed from New to Code Review
  • Assignee changed from Steve Breker to Nick Wilkinson

#5 Updated by Steve Breker over 3 years ago

  • Status changed from Code Review to QA/Review

JGC has given this the thumbs-up.

Merged to qa/2.4.x. Ready for QA.

#6 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Dan Gillean

#7 Updated by Dan Gillean over 3 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

Yay!

Also available in: Atom PDF