Bug #10856

Sidebar treeview's "xx more" expand button cannot be translated

Added by Dan Gillean over 2 years ago. Updated over 1 year ago.

Status:VerifiedStart date:02/03/2017
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:I18N
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

See attached screenshot - the "%1% more" string used in the sidebar treeview to show more sibling descriptions is not wrapped with the i18n helper.

See: https://github.com/artefactual/atom/blob/8bd522ce857e75d0b5ccf58b9e35c66b5b47826f/lib/helper/QubitHelper.php#L251

treeview-more.png (27.3 KB) Dan Gillean, 02/03/2017 03:22 PM

History

#1 Updated by Dan Gillean over 2 years ago

#2 Updated by Nick Wilkinson almost 2 years ago

  • Assignee set to Mike Cantelon

Hi Mike, can you please look into this?

#3 Updated by Mike Cantelon almost 2 years ago

Will do!

#4 Updated by Mike Cantelon almost 2 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#5 Updated by Steve Breker almost 2 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Nick Wilkinson to Mike Cantelon

CR complete. Looks great!

#6 Updated by Mike Cantelon almost 2 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x.

#7 Updated by Dan Gillean almost 2 years ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

Hi Mike,

Any thoughts on how I can test this? I pulled in the latest changes, restarted all services and reindexed. Then I went to a description with many children, flipped the UI to French, and was looking through the options in the translation panel in AtoM, but I didn't see anything... other methods? Other ideas?

#8 Updated by Mike Cantelon almost 2 years ago

Hi Dan. Maybe there's no French translation for "more". I'll check that out.

#9 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Hi Dan,

I figured out how to test this:

  1. Edit apps/qubit/i18n/fr/messages.xml
  2. Add this XML under the body tag:
      <trans-unit id="a191b2120c9efa7b0c1411d6989e325561707ddb">
        <source>%1% more</source>
        <target>%1% plus</target>
      </trans-unit>

Then when you switch from English to French in AtoM you should see "more" change to "plus".

Next release when this gets pushed to Transifex then it'll be translated permanently.

#10 Updated by Dan Gillean over 1 year ago

  • Target version set to Release 2.5.0

#11 Updated by Dan Gillean over 1 year ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

Also available in: Atom PDF