Feature #10962

Add logic to allow disabling of nested set updating during term deletion (for bulk deletion)

Added by Mike Cantelon about 2 years ago. Updated about 1 month ago.

Status:VerifiedStart date:03/09/2017
Priority:MediumDue date:
Assignee:Mike Cantelon% Done:

0%

Category:Taxonomy / Term
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Each time a term is deleted the nested set is updated. This makes bulk deletion of terms very slow. If only deleting leaf nodes (reverse sorting on lft) it should be safe to not update the nested set until the bulk deletion is complete. Add logic that will allow nested set updating to be disabled when deleting a term.

History

#2 Updated by Mike Cantelon about 2 years ago

  • Tracker changed from Task to Feature

#3 Updated by Dan Gillean about 2 years ago

  • Target version set to Release 2.4.0

#4 Updated by Mike Cantelon about 2 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#5 Updated by Nick Wilkinson about 2 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

#6 Updated by Mike Gale about 2 years ago

  • Assignee changed from Mike Gale to Mike Cantelon

#7 Updated by Nick Wilkinson almost 2 years ago

  • Assignee changed from Mike Cantelon to José Raddaoui Marín

Hi Radda, re-assigning to you to balance out workloads.

#8 Updated by José Raddaoui Marín almost 2 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#9 Updated by Mike Cantelon almost 2 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

I took a different approach, trying Radda's recommendation:

PR for CR: https://github.com/artefactual/atom/pull/596

#10 Updated by Nick Wilkinson almost 2 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, assigning back to you for CR.

#11 Updated by José Raddaoui Marín almost 2 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#12 Updated by Mike Cantelon almost 2 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to José Raddaoui Marín

Hi Radda... I've made the changes you recommended.

#13 Updated by José Raddaoui Marín almost 2 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

Looks good!

#14 Updated by Mike Cantelon almost 2 years ago

  • Target version changed from Release 2.4.0 to Release 2.5.0

Waiting until after 2.4 release to merge into dev branch.

#15 Updated by Mike Cantelon over 1 year ago

Merged into qa/2.5.x.

#16 Updated by Mike Cantelon 10 months ago

  • Status changed from Feedback to Verified

Marking as verified as this seems to be working.

#17 Updated by Mike Cantelon about 1 month ago

  • Target version deleted (Release 2.5.0)

#18 Updated by Dan Gillean about 1 month ago

  • Target version set to Release 2.5.0

Also available in: Atom PDF