Filters button broken on mobile
|Assignee:||Dan Gillean||% Done:|
|Target version:||Release 2.4.0|
|Google Code Legacy ID:||Tested version:||2.3, 2.4|
Testing on an iPhone 6, the Filters button/toggle no longer works, i.e. the list of facets does not expand. When you press on it, it flickers but otherwise doesn't respond.
I'm not set up with the right tools to access the debug console on the phone, so I don't know what error is being raised.
Observed on a recent version of 2.4 (local test box), the production version of Archives Canada, and the 2.3 demo site.
Using an emulator, it looks like this is also an issue with iPhone 5.
I'm pretty sure I remember seeing this working :)
#1 Updated by Tim Hutchinson over 3 years ago
I'm venturing out of my depth, but I'm wondering if this commit could be the culprit:
There is both a facet-header class and facets-header. Facets-header seems to be relevant one here, but this commit appears to have merged the click actions (in dominion.js) for the two classes, starting around line 126.
#6 Updated by Steve Breker over 3 years ago
- Status changed from New to QA/Review
- Assignee changed from Steve Breker to Nick Wilkinson
I've tested the change against qa/2.4.x and stable/2.3.x - all looks good. Fix is merged and PR is closed. I have cherry-picked this fix to stable/2.3.x as the same issue affects that release.
Issue can be replicated in Chrome using the built in Developer Tools (toggle device toolbar) and narrowing the field of view until the facets are replaced with the Filters dropdown. Without Darryl's patch, the button is present but it is unresponsive when clicked. When his change is in place, the Filters dropdown works as expected.
I also tested with both the Dominion and Archives Canada themes - the issue affected both themes, and the fix corrects it in both.
Run 'php symfony cc' after deploying.