Bug #11177

Changing "users" menu name breaks user administration page

Added by Mike Gale about 2 years ago. Updated 9 months ago.

Status:VerifiedStart date:05/18/2017
Priority:MediumDue date:
Assignee:Nick Wilkinson% Done:

0%

Category:User management
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.5
Sponsored:No Requires documentation:

Description

To reproduce:
1. Login as an admin account
2. Go settings -> menus
3. Click to edit "users" menu item under mainMenu -> admin -> users
4. Change menu name to something like "users2"
5. Attempt to go to admin -> users and to modify some users

Result: You get a broken, partially rendered page. Log says: 2017/05/18 13:35:18 [error] 10992#10992: *83 FastCGI sent in stderr: "PHP message: PHP Fatal error: Call to a member function getChildren() on a non-object in /home/mikeg/workspace/atom/apps/qubit/modules/user/templates/_aclMenu.php on line 2

Expected result: This shouldn't break it!

I strongly suspect the issue is this line of code specifically: https://github.com/artefactual/atom/blob/qa/2.4.x/apps/qubit/modules/user/actions/aclMenuComponent.class.php#L33 -- as it assumes a hardcoded menu name of "users".

I'm not sure what the ideal solution is, but I don't think users should ever be able to change menu names (they can change labels np). Perhaps we should remove this functionality from the AtoM UI? Maybe there's a better solution.


Related issues

Related to Access to Memory (AtoM) - Task #11186: Allow key menu item names to be locked Verified 05/23/2017

History

#1 Updated by Mike Gale about 2 years ago

  • Related to Task #11186: Allow key menu item names to be locked added

#2 Updated by Mike Cantelon 10 months ago

This might be solved as part of #12167 (currently under code review).

#3 Updated by Mike Cantelon 10 months ago

#12167 doesn't solve this (forgot to add this specific menu to the list of locked menus).

#4 Updated by Dan Gillean 10 months ago

  • Status changed from New to Feedback
  • Assignee set to Mike Cantelon

Not sure if this relates specifically to this issue or to #12167, but getting the following error in my local vagrant env trying to update:

[wrapped: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'menu.RENAMEABLE' in 'field list']

#5 Updated by Mike Cantelon 10 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Should be fixed now in qa/2.5.x. You might need to drop your AtoM DB before this'll work if you applied that previous migration to it.

#6 Updated by Michelle Curran 9 months ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Dan Gillean to Nick Wilkinson

#7 Updated by Michelle Curran 9 months ago

  • Tested version 2.5 added

Verified in local vagrant env tracking qa/2.5.x.

#8 Updated by Dan Gillean 9 months ago

  • Target version set to Release 2.5.0

Also available in: Atom PDF