Changing "users" menu name breaks user administration page
|Assignee:||Nick Wilkinson||% Done:|
|Target version:||Release 2.5.0|
|Google Code Legacy ID:||Tested version:||2.5|
1. Login as an admin account
2. Go settings -> menus
3. Click to edit "users" menu item under mainMenu -> admin -> users
4. Change menu name to something like "users2"
5. Attempt to go to admin -> users and to modify some users
Result: You get a broken, partially rendered page. Log says: 2017/05/18 13:35:18 [error] 10992#10992: *83 FastCGI sent in stderr: "PHP message: PHP Fatal error: Call to a member function getChildren() on a non-object in /home/mikeg/workspace/atom/apps/qubit/modules/user/templates/_aclMenu.php on line 2
Expected result: This shouldn't break it!
I strongly suspect the issue is this line of code specifically: https://github.com/artefactual/atom/blob/qa/2.4.x/apps/qubit/modules/user/actions/aclMenuComponent.class.php#L33 -- as it assumes a hardcoded menu name of "users".
I'm not sure what the ideal solution is, but I don't think users should ever be able to change menu names (they can change labels np). Perhaps we should remove this functionality from the AtoM UI? Maybe there's a better solution.
#4 Updated by Dan Gillean almost 4 years ago
- Status changed from New to Feedback
- Assignee set to Mike Cantelon
Not sure if this relates specifically to this issue or to #12167, but getting the following error in my local vagrant env trying to update:
[wrapped: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'menu.RENAMEABLE' in 'field list']