Task #11260

Remove code that strips English articles from generated slugs

Added by Dan Gillean about 3 years ago. Updated almost 3 years ago.

Status:VerifiedStart date:06/12/2017
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:Information objectEstimated time:4.00 hours
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Currently when slugs are generated in AtoM, the English articles "a", "an", and "the" are stripped from the generated slugs. This can be a problem in some cases - for example:

  • trying to generate reference-code based slugs when the identifiers are alpha-based - e.g. A, B, C, D... A will be stripped
  • trying to generate title based slugs with a similar convention - e.g. "Series A" becomes "series"

This ticket is to investigate and identify the related code, and provide an estimate for the amount of work required to change the slug generation so articles are not removed. The relevant code can be seen here:

Going forward, English articles "a," "an," and the "the" will no longer be stripped from slugs.

History

#2 Updated by Dan Gillean about 3 years ago

Documentation in the following section should be reviewed and updated:

#3 Updated by Steve Breker about 3 years ago

I have completed the change to prevent the English articles 'a', 'an' and 'the' being removed from slugs.

PR complete - ready for code review: https://github.com/artefactual/atom/pull/572

#4 Updated by Steve Breker about 3 years ago

  • Status changed from New to Code Review
  • Assignee changed from Steve Breker to Nick Wilkinson

#5 Updated by Nick Wilkinson about 3 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, for when you're back -- assigning this to yo for CR.

#6 Updated by José Raddaoui Marín about 3 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Steve Breker

Looks good!

#7 Updated by Steve Breker about 3 years ago

Merged to qa/2.4.x.

4c49d01446ae00801e440554f1b89fc37fa9936a

#8 Updated by Steve Breker about 3 years ago

  • Status changed from Feedback to Deploy
  • Assignee changed from Steve Breker to Nick Wilkinson

#9 Updated by Nick Wilkinson about 3 years ago

  • Assignee changed from Nick Wilkinson to Darren Craze

#10 Updated by Santiago Collazo about 3 years ago

  • Private changed from No to Yes

#11 Updated by Santiago Collazo about 3 years ago

  • Private changed from Yes to No

#13 Updated by Nick Wilkinson about 3 years ago

  • Status changed from Deploy to QA/Review
  • Assignee deleted (Darren Craze)

#14 Updated by Sara Allain almost 3 years ago

  • Status changed from QA/Review to Verified
  • Assignee set to Sara Allain

Looks good!

#15 Updated by Dan Gillean almost 3 years ago

  • Assignee deleted (Sara Allain)
  • Requires documentation deleted (Yes)

Also available in: Atom PDF