Bug #11311

CSV import does not check file type before proceeding with import

Added by Dan Gillean almost 2 years ago. Updated over 1 year ago.

Status:VerifiedStart date:06/29/2017
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:CSV import
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.4
Sponsored:No Requires documentation:

Description

  • Log in and navigate to Import > CSV
  • Select a non-CSV file, such as an EAD XML document (see attached example) as the file for upload
  • Start the upload
Error encountered
  • AtoM does not verify that the file is a CSV or do basic sanity-checking before triggering the import
  • The import proceeds and is marked as successful
  • AtoM generates a bunch of empty information objects (approx 244 created with sample EAD file attached)
Expected outcome
  • AtoM double-checks the file type before proceeding
  • If the file is not a CSV, an error is thrown and the user is notified that the file type is incorrect

isad-ead-crosswalk-2.4.xml Magnifier (10.8 KB) Dan Gillean, 06/29/2017 08:34 AM

History

#1 Updated by Nick Wilkinson over 1 year ago

  • Assignee set to Mike Cantelon

Hi Mike, can you please look into this?

#2 Updated by Mike Cantelon over 1 year ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#3 Updated by Nick Wilkinson over 1 year ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, assigning to you for CR.

#4 Updated by Mike Cantelon over 1 year ago

Note: This gives us lists of available import/export columns for major data types... these lists could also be integrated into the csv:import-check too to help weed out misspelled column names, etc.

#5 Updated by José Raddaoui Marín over 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#6 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x.

#7 Updated by Dan Gillean over 1 year ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Target version set to Release 2.5.0

Also available in: Atom PDF