Bug #11352

Generate DIP chain link got orphaned

Added by Joel Dunham almost 5 years ago. Updated almost 5 years ago.

Status:QA/ReviewStart date:07/12/2017
Priority:HighDue date:
Assignee:-% Done:

0%

Category:Workflow
Target version:Release 1.7.0
Google Code Legacy ID: Pull Request:https://github.com/artefactual/archivematica/pull/675
Sponsored:No Requires documentation:

Description

The "Check if DIP should be generated" link (f1e286f9-4ec7-4e19-820c-dae7b8ea7d09) was orphaned (i.e., there is no way to get to it) by https://github.com/artefactual/archivematica/commit/f1e04ffe528156f83a137c6c4dbd228e6b53f5b2. This means a DIP will always get generated. See screenshot of workflow.

am-worfklow-generate-dip-orphaned.png (632 KB) Joel Dunham, 07/12/2017 03:09 PM

History

#1 Updated by Joel Dunham almost 5 years ago

  • Status changed from New to Code Review
  • Assignee changed from Joel Dunham to Nick Wilkinson
  • Pull Request set to https://github.com/artefactual/archivematica/pull/675

Hey Nick,

I've already requested CRs from Jesús and Mike.

#2 Updated by Jesús García Crespo almost 5 years ago

  • Assignee changed from Nick Wilkinson to Mike Cantelon

Mike, this is highly related to the last two PRs you've been working on - I think it makes sense that you take a look to Joel fixes.

#3 Updated by Mike Cantelon almost 5 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Mike Cantelon to Joel Dunham

Looks good to me... thanks!

#4 Updated by Joel Dunham almost 5 years ago

  • Status changed from Feedback to Deploy
  • Assignee changed from Joel Dunham to Nick Wilkinson

The relevant PR here has been merged: https://github.com/artefactual/archivematica/pull/675

#5 Updated by Nick Wilkinson almost 5 years ago

  • Status changed from Deploy to QA/Review
  • Assignee deleted (Nick Wilkinson)

Also available in: Atom PDF