Bug #11363

Unable to drag directories from Backlog in Appraisal Tab

Added by Joel Dunham almost 5 years ago. Updated over 4 years ago.

Status:VerifiedStart date:07/14/2017
Priority:HighDue date:
Assignee:Sara Allain% Done:

0%

Category:SIP Arrange
Target version:Release 1.7.0
Google Code Legacy ID: Pull Request:
Sponsored:No Requires documentation:

Description

Getting the following error in the JS console for each transfer in Backlog displayed after "Search transfer backlog" is clicked.

@TypeError: (0 , _jquery2.default)(...).draggable is not a function
    at Object.link (appraisal_tab.js:96738)
    at appraisal_tab.js:1990
    at invokeLinkFn (appraisal_tab.js:11070)
    at nodeLinkFn (appraisal_tab.js:10459)
    at compositeLinkFn (appraisal_tab.js:9699)
    at publicLinkFn (appraisal_tab.js:9564)
    at lazyCompilation (appraisal_tab.js:9955)
    at boundTranscludeFn (appraisal_tab.js:9742)
    at controllersBoundTransclude (appraisal_tab.js:10509)
    at ngIfWatchAction (appraisal_tab.js:28153) "<span tree-draggable="" file-type="backlog" uuid="{{ node.id }}" ng-if="!node.not_draggable" class="ng-binding ng-scope">" 

Recent changes to this file—https://github.com/artefactual-labs/appraisal-tab/blob/73a813a5cf2b4095ce072f6b124fd91830d0a969/app/tree/tree.directive.js—may be responsible.

My minimal research indicated that this might be relevant: https://stackoverflow.com/questions/2895894/jquery-ui-draggable-is-not-a-function.

History

#1 Updated by Nick Wilkinson almost 5 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, can you please investigate?

#2 Updated by José Raddaoui Marín almost 5 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

It looks like we upgraded some dependencies in the AT webpack file used in AM qa/1.x, including a jQuery upgrade from v.1.11.3 to v1.12.4, which causes a mismatch between the AM and AT jQuery versions. We were also loading jQuery two times in some AM templates, three in the AT page, including the one from the webpack file. More info in the pull requests:

https://github.com/artefactual-labs/appraisal-tab/pull/159
https://github.com/artefactual/archivematica/pull/678

#3 Updated by Nick Wilkinson almost 5 years ago

  • Assignee changed from Nick Wilkinson to Jesús García Crespo

#4 Updated by Jesús García Crespo almost 5 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

Added my comments to the PR.

#5 Updated by José Raddaoui Marín almost 5 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

#6 Updated by Nick Wilkinson almost 5 years ago

  • Status changed from Code Review to QA/Review
  • Assignee deleted (Jesús García Crespo)

PR 159 has been merged, PR 678 has been CRd (and possibly bumped to a subsequent release).

#7 Updated by José Raddaoui Marín over 4 years ago

  • Status changed from QA/Review to Deploy
  • Assignee set to Nick Wilkinson

Pull requests are now merged so this should be ready for deploy using AM qa/1.x and qa/1.7.x from the AM Ansible role version.

Please notice the new dependency and step in the AM Ansible role to build the front-end assets, the one deploying this changes should verify this is happening without problem:

https://github.com/artefactual-labs/ansible-archivematica-src/commit/cdc48ec2e67ad806df081c9478b6250dbe4fe6ed

#8 Updated by Nick Wilkinson over 4 years ago

  • Status changed from Deploy to QA/Review
  • Assignee changed from Nick Wilkinson to Sara Allain

Hi Sara, assigning this to you for QA for when qa/1.x is redeployed for review (on #10807).

#9 Updated by Sara Allain over 4 years ago

  • Status changed from QA/Review to Verified

Looks good!

Also available in: Atom PDF