Bug #11639

Symfony task for building models from schemas doesn't work with PHP 7

Added by Mike Cantelon over 1 year ago. Updated over 1 year ago.

Status:VerifiedStart date:10/23/2017
Priority:MediumDue date:
Assignee:Nick Wilkinson% Done:

0%

Category:CLI tools
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:No

Description

When running ./symfony propel:build-models errors result in the current codebase, and earlier versions, in our newer, PHP 7 Vagrant boxes.

When using an older Vagrant box with PHP 5.x , the task still works (providing a workaround, if needed).

History

#1 Updated by Mike Cantelon over 1 year ago

  • Status changed from New to Code Review
  • Assignee set to Nick Wilkinson

PR for CR that fixes issue (tested in PHP 5.5 and PHP 7):

https://github.com/artefactual/atom/pull/648

#2 Updated by Nick Wilkinson over 1 year ago

  • Assignee changed from Nick Wilkinson to Steve Breker

Hi Steve, passing to you for CR.

#3 Updated by Steve Breker over 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Steve Breker to Mike Cantelon

CR looks good.

#4 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Steve Breker

Thanks Steve! Merged. Can you QA if you have availability given you know the issue? Otherwise you can pass to Nick.

#5 Updated by Steve Breker over 1 year ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Steve Breker to Nick Wilkinson

Hi Mike - QA test complete.

I have verified that:
- the errors we were seeing prior to your fix when running php symfony propel:build-sql no longer occur
- modifications to config/schema.yml are picked up by the build-sql task and are successfully incorporated into data/sql/lib.model.schema.sql

Looks good to me!

Also available in: Atom PDF