Bug #11752

Clipboard state not being maintained on description view pages

Added by Dan Gillean over 1 year ago. Updated over 1 year ago.

Status:VerifiedStart date:11/30/2017
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Clipboard
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.5
Sponsored:No Requires documentation:

Description

Reproduced in AtoM Vagrant box 2.5, in Chrome 62.0.3202.94 and Firefox 57.0.1 on Win10.

To reproduce
  • Navigate to a description's view page
  • Add to clipboard
  • Navigate to home page
  • Return to view page of pinned description
Resulting error
  • Clipboard icon is not activated - says "Add" even though item is already pinned to clipboard
Expected result
  • Clipboard icon maintains state while users navigate

History

#3 Updated by Mike Cantelon over 1 year ago

  • Status changed from New to Code Review
  • Assignee set to Nick Wilkinson

#4 Updated by Mike Cantelon over 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Nick Wilkinson to Mike Cantelon

Radda has code reviewed.

#5 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x and ready for QA.

#6 Updated by Dan Gillean over 1 year ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

Tested in qa/2.5.x vagrant box on Chrome and IE 11.

Navigation in the full-width treeview will break the clipboard state - likely because it is using AJAX to do a partial page reload on selection, rather than a full page refresh on click. To reproduce:

  • Navigate to a description with descendants
  • Use the clipboard link on the view page to add the fonds to the clipboard
  • Use the full-width treeview to navigate to a child record
  • Add the child to the clipboard
  • Return to the parent. Observe - then return to the child.
Resulting error
  • Both parent and child records, when using the full-width treeview for navigation, show the records added to the clipboard as not yet added. Forcing a hard page refresh (e.g. CTRL+R) will display the correct state, but the partial page load delivered by AJAX loading does not maintain the clipboard button state.
Expected result
  • In the steps outlined above, both parent and child should be shown as pinned to the clipboard when navigating away and returning
  • Treeview AJAX calls should maintain the state of the clipboard button

#7 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#8 Updated by Nick Wilkinson over 1 year ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, can you please CR this work?

#9 Updated by José Raddaoui Marín over 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#10 Updated by Mike Cantelon over 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x.

#11 Updated by Dan Gillean over 1 year ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

Tested in Chrome 63.0.3239.132 on Win10 - did not resolve the issue described in note-6 for me.

  • Find a description with a hierarchy - view a parent record.
  • Add record to clipboard
  • Click on child node
  • Return to parent node and look at clipboard link on page:

Resulting error clipboard button on view page sidebar is not toggled
Expected result clipboard button on view page sidebar maintains state when navigating via full-width treeview.

#12 Updated by Mike Cantelon over 1 year ago

  • Assignee changed from Mike Cantelon to Dan Gillean

Hi Dan. I installed AtoM, in a VM with bridged networking so I can access it with browsers, on a Windows 7 box to test. Clipboard button state worked with Chrome 63, Firefox 57, and IE 11 for me. Can you try, if you haven't already, clearing your browser cache and restarting the AtoM VM/server you're using to test?

#13 Updated by Mike Cantelon over 1 year ago

How I was testing was, once full width treeview was set up and working and I'd created a hierarchy of descriptions:

  1. Add the top-level description to the clipboard using the clipboard button on the right side of the content area of the page
  2. Navigate to a child description (which we'll call "Child A") to confirm that the clipboard button changes (to show the child isn't in the clipboard)
  3. Navigate to another child description (which we'll call "Child B")
  4. Add this child description to the clipboard using the clipboard button
  5. Navigate back to Child A and confirm that the clipboard button state changes to indicate that Child A isn't in the clipboard
  6. Navigate back to the top-level description and confirm that the clipboard button state changes to indicate that the top-level description is in the clipboard

#14 Updated by Dan Gillean over 1 year ago

  • Status changed from Feedback to Verified

Sorry about that Mike - you're right. Maybe it was a cache issue. Anyway it seems to work fine for me now, in FF57 and Chrome 63.

Also available in: Atom PDF