Bug #11828

Authority records left side links shows Creator and Subject when only Creator is expected

Added by Darren Craze almost 4 years ago. Updated over 1 year ago.

Status:VerifiedStart date:12/28/2017
Priority:HighDue date:
Assignee:-% Done:

100%

Category:Search / Browse
Target version:Release 2.4.1
Google Code Legacy ID: Tested version:2.4
Sponsored:Yes Requires documentation:

Description

When viewing an Authority record the left side shows a "Creator of" section with links as expected and the same links listed under a "Subject of" section.

Reproduced on atomdemo and on multiple customer instances.

To reproduce
  • Navigate to an authority record view page that is the Creator of 1 or more Descriptions
Resulting error
  • Both "Creator of" and "Subject of" sections are displayed on the left side showing the same links to the Descriptions
Expected result
  • Only the "Creator of" section would be displayed unless the authority is genuinely a Subject within the Description

Related issues

Related to Access to Memory (AtoM) - Feature #10048: Provide pagination and "show all" link in authority recor... Verified 06/09/2016

History

#2 Updated by Dan Gillean almost 4 years ago

  • Priority changed from Medium to High
  • Target version changed from Release 2.5.0 to Release 2.4.1

#4 Updated by Dan Gillean almost 4 years ago

  • Related to Feature #10048: Provide pagination and "show all" link in authority records linked descriptions lists added

#5 Updated by Dan Gillean almost 4 years ago

I've added a link to #10048 for context. This behavior has been present in AtoM for a long time (automatically adding a creator as a subject), but prior to the changes in #10048, it was not being shown on the actor view page.

I think that ultimately the solution should be to remove the automatic behavior - not just suppress the display on the view page of the authority record.

#6 Updated by Darren Craze almost 4 years ago

  • Assignee set to Nick Wilkinson

#12 Updated by Nick Wilkinson almost 4 years ago

  • Assignee changed from Nick Wilkinson to Darren Craze

#14 Updated by Dan Gillean almost 4 years ago

  • Sponsored changed from No to Yes

#17 Updated by Mike Gale almost 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Darren Craze to José Raddaoui Marín

Hi Radda,

I found a way to remove duplicate links from the "Subject of" heading when viewing authority records' related archival descriptions. Basically, make the ES search check for if there is an event for the authority record related to that description, if there isn't, put it under Subject of heading (name access point only). If there is an event, we don't put it under Subject of because that means it's a creator (or other type of relationship) and the link to the archival description should go under the appropriate heading "Creator of", "Accumulator of" etc..

I was talking to Dan though and he feels we should completely remove automatically adding authority records to name access points (Subject of) if they are a creator or other relationship. I'm a bit nervous about the time it'd take to do this though; our ES indexing assumes the current behavior (which was introduced in 2.0) and it'd be changing the ES index. Also there's code like this: https://github.com/artefactual/atom/blob/qa/2.5.x/apps/qubit/modules/informationobject/templates/_nameAccessPoints.php#L20 which makes me think database schema changes and migration too if we want to remove it there as well?

My question is, what was your time estimate based on? Did you think 8 hours to completely remove automatically adding to name access points for creators and everything? Or was the estimate just to remove that duplicate link under the Subject Of heading when viewing authority records?

thanks

#18 Updated by José Raddaoui Marín almost 4 years ago

  • Assignee changed from José Raddaoui Marín to Mike Gale

Hi Mike,

The estimate was for all, we don't need to do any database change that I'm aware of. The duplication is made in the IO index page (in the link you put) and in the ES index in here. But it's pulling from different sources, no real duplication is made in the database AFAIK.

#19 Updated by Mike Gale almost 4 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

Ready to test--it is merged in qa/2.5.x (6ce573a3ccb70bd293985f64d9874621633c75e4) for now until we test it, when we're satisfied it's OK we'll merge into stable/2.4.x in anticipation of 2.4.1 release.

#20 Updated by Dan Gillean almost 4 years ago

  • Status changed from QA/Review to In progress
  • Assignee changed from Dan Gillean to Mike Gale

Looks good! You wanna backport it to stable/2.4.x and I will give it a quick test there?

#21 Updated by Mike Gale almost 4 years ago

  • Assignee changed from Mike Gale to Dan Gillean

should be in stable/2.4.x now

#22 Updated by Dan Gillean almost 4 years ago

  • Status changed from In progress to Verified

Looks good!

#23 Updated by Dan Gillean over 3 years ago

  • Requires documentation set to Yes

Updating this ticket so requires documentation is set to "Yes" - a note about the previous behavior appears here in the current docs, second bullet point:

"When a creator name is added to an archival description, the name is also automatically added as a name access point - there is no need to add the creator as a name (subject) access point manually."

We should remove this from the docs.

#24 Updated by Dan Gillean over 1 year ago

  • Assignee deleted (Dan Gillean)
  • % Done changed from 0 to 100
  • Requires documentation deleted (Yes)

Finally got around to removing this mention in the 2.6 docs: https://github.com/artefactual/atom-docs/commit/63eeeaa0d450ae39662581ee2cf48949b99d4c4b

Also available in: Atom PDF