Bug #11899

Update insert statement in generate-slugs task

Added by Steve Breker about 1 year ago. Updated about 1 year ago.

Status:VerifiedStart date:01/23/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:CLI toolsEstimated time:4.00 hours
Target version:Release 2.4.1
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:No

Description

Update the generate-slugs task to use PDO classes instead of sql insert. We should be using PDO parameter/value binding here:

https://github.com/artefactual/atom/blob/qa/2.5.x/lib/task/propel/propelGenerateSlugsTask.class.php#L199

http://php.net/manual/en/pdostatement.execute.php

History

#1 Updated by Steve Breker about 1 year ago

  • Assignee changed from Steve Breker to Nick Wilkinson

Ready for code review. PR is here:

https://github.com/artefactual/atom/pull/655

#2 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing this to you for CR.

#3 Updated by José Raddaoui Marín about 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from José Raddaoui Marín to Steve Breker

#4 Updated by Steve Breker about 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Steve Breker to Nick Wilkinson

Merged to qa/2.5.x. Ready for QA.

Regarding QA: There should be no differences in how the CLI generate-slugs task works after deploying this change. This change affects how the query that inserts new slugs prepares the values that are being inserted into the DB. If the CLI task can create slugs, then it is working correctly.

Let me know when this can be picked to stable/2.4.x.

Steve

#5 Updated by Dan Gillean about 1 year ago

Looks good, Steve - feel free to backport.

#6 Updated by Dan Gillean about 1 year ago

  • Status changed from QA/Review to In progress
  • Assignee changed from Nick Wilkinson to Steve Breker

#7 Updated by Steve Breker about 1 year ago

  • Status changed from In progress to QA/Review
  • Assignee changed from Steve Breker to Nick Wilkinson

This commit has been picked to stable/2.4.x.

Commit: Use PDO data binding gen slugs task, Refs# 11899
Hash: 62372ff2ee6d32488cfcfeb34917dfeb61f7b7cb

#8 Updated by Nick Wilkinson about 1 year ago

  • Assignee deleted (Nick Wilkinson)

#9 Updated by Dan Gillean about 1 year ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF