Task #11906

Avoid unnecessary ES update of related description when a term name is changed through the GUI

Added by José Raddaoui Marín over 1 year ago. Updated about 1 year ago.

Status:VerifiedStart date:01/25/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:Performance / scalability
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

When a tern name is changed, it triggers an update for all its related description in ES. This is necessary for terms that are fully indexed inside its related description, but it isn't for terms where the related description only store the term id.

So far we know that places, subjects and genres should trigger that update and that material types shouldn't.

Also, that update should be done asynchronously, as noted in #11855.

update_term_name.php Magnifier (2.77 KB) José Raddaoui Marín, 01/25/2018 12:00 PM


Related issues

Related to Access to Memory (AtoM) - Bug #11855: Search index is not updated when edits affect descendant ... Verified 01/10/2018

History

#1 Updated by José Raddaoui Marín over 1 year ago

  • Description updated (diff)

#3 Updated by José Raddaoui Marín over 1 year ago

  • Description updated (diff)

#4 Updated by José Raddaoui Marín over 1 year ago

  • Related to Bug #11855: Search index is not updated when edits affect descendant records added

#5 Updated by José Raddaoui Marín over 1 year ago

Attached is a script to update a term name and its related archival descriptions in the ES index. It allows to add/edit/remove the term name on any culture.

Execution example, from the AtoM folder:

$ php symfony tools:run update_term_name.php
Have you created a backup of the database? [y/N]: y
Enter taxonomy name (case insensitive): material type
Enter taxonomy name culture (default: en): 
Enter current term name (case insensitive): graphic material
Enter current term name culture (default: en): 
Enter new term name (leave empty to remove): Photographs
Enter new term name culture (default: en): 
Term name updated.
Updating related descriptions ..... Done!
 - 17 descriptions updated.

#6 Updated by Nick Wilkinson over 1 year ago

  • Assignee set to Nick Wilkinson

Temporarily assigning this to myself so I don't loose track of it.

#7 Updated by Nick Wilkinson over 1 year ago

  • Assignee changed from Nick Wilkinson to Mike Gale

Hi Mike, can you please look into this? It's related to #11855, which you're also working on.

#8 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

Hi Radda, reassigning this to you.

#9 Updated by José Raddaoui Marín about 1 year ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

#10 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Nick Wilkinson to Steve Breker

HI Steve, passing to you for CR.

#11 Updated by Steve Breker about 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Steve Breker to José Raddaoui Marín

CR complete. No feedback. Looks good.

#12 Updated by José Raddaoui Marín about 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Hi Dan,

Only places, subjects and genres should trigger the update of its related descriptions after this changes. And they should do it using a job and showing a notification.

#13 Updated by José Raddaoui Marín about 1 year ago

This changes are included in the work for #11855 so, if we decide to add that feature to stable/2.4.x, this one will be added too.

#14 Updated by Dan Gillean about 1 year ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

This seems to work great so far!

Also available in: Atom PDF