Bug #11944
Users cannot enter ampersand character into global search box
| Status: | Verified | Start date: | 02/01/2018 | |
|---|---|---|---|---|
| Priority: | Medium | Due date: | ||
| Assignee: | Dan Gillean | % Done: | 0% | |
| Category: | Search / Browse | |||
| Target version: | Release 2.5.0 | |||
| Google Code Legacy ID: | Tested version: | 2.4 | ||
| Sponsored: | No | Requires documentation: |
Description
- Try to enter a search term such as "coffee & tea"
- & cannot be entered into global search box
- entering Shift+7 (aka key combo to create & character on most en keyboard layouts) shifts focus to next UI element instead (similar to tab key)
- term is entered into global search box
- Ampersand character does not cause UI to shift focus to next page element
- the double ampersand - && - is reserved in ES, and can be used in a search query in place of a literal AND for boolean searching - as such, ampersand characters should work in the Global search box
- We should double-check accessibility best practices to ensure that shift+7 is not a commonly known alternative to the tab key for UI keyboard navigation
Related issues
History
#1 Updated by Mike Cantelon 8 months ago
- Status changed from New to Code Review
PR for CR: https://github.com/artefactual/atom/pull/808
#2 Updated by Steve Breker 7 months ago
- Status changed from Code Review to Feedback
- Assignee set to Mike Cantelon
Looked at PR - LGTM
#3 Updated by Mike Cantelon 7 months ago
- Status changed from Feedback to QA/Review
- Assignee changed from Mike Cantelon to Dan Gillean
Merged into qa/2.5.x.
#4 Updated by Dan Gillean 7 months ago
- Related to Task #12725: Update deprecated keyboard handling events in JS added
#5 Updated by Dan Gillean 5 months ago
- Status changed from QA/Review to Verified
- Target version set to Release 2.5.0