Bug #11963

Unused code in the finding aid generation: $exportLangauge variable not used

Added by Dan Gillean over 1 year ago. Updated about 1 year ago.

Status:VerifiedStart date:02/08/2018
Priority:LowDue date:
Assignee:Dan Gillean% Done:


Category:Finding aids
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.4, 2.5
Sponsored:No Requires documentation:No


First reported by a community user via GitHub issues, 2018-02-07: https://github.com/artefactual/atom/issues/663

    // Determine language(s) used in the export
    $exportLanguage = sfContext::getInstance()->user->getCulture();
    $sourceLanguage = $this->resource->getSourceCulture();

It appears that the $exportLanguage variable being set here is not used elsewhere in the finding aid generation process. This dead code can be removed, or the finding aid generation code could be refactored to better support i18n use cases.


#1 Updated by Mike Cantelon about 1 year ago

  • Status changed from New to Code Review
  • Assignee set to Nick Wilkinson

#2 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#3 Updated by José Raddaoui Marín about 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#4 Updated by Mike Cantelon about 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x. Not sure if this needs to go to QA or not. ;)

#5 Updated by Dan Gillean about 1 year ago

  • Status changed from QA/Review to Verified
  • Target version set to Release 2.5.0

Well, I tested finding aid generation, and it still worked :)

Also available in: Atom PDF