Bug #12067

Trim pipe separated import fields on CSV import

Added by Steve Breker about 1 year ago. Updated about 1 month ago.

Status:VerifiedStart date:03/26/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:CSV import
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

When performing a CSV Information Object import, extra embedded whitespace in the pipe separated event creators list are not trimmed.

e.g.
<space>S. Smith<space>|<space>T. Anderson<space

These names will be imported, and actors will be create with the leading and trailing whitespace intact. This will result in a new actor getting created even if actor 'S. Smith' (without spaces) already exists.

All pipe separated fields should be checked for this problem.

History

#1 Updated by Steve Breker about 1 year ago

This change trims all pipe separated elements contained in an import
CSV file. This was not occurring previously and extra leading and
trailing spaces were appearing in the import, and in some cases,
preventing correct matching when match is based off these fields.

Additionally I have added code to ensure culture and other fields are
trimmed. If these fields has leading or trailing spaces in the csv, they
where previously not being trimmed, and the term lookups would fail.

Custom column handlers had a similar issue and require trimming of
values to ensure leading and trailing spaces in the csv field do not
affect the import.

#2 Updated by Steve Breker about 1 year ago

  • Status changed from New to Code Review
  • Assignee changed from Steve Breker to Nick Wilkinson

#3 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#4 Updated by José Raddaoui Marín about 1 year ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Steve Breker

#5 Updated by Steve Breker about 1 year ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Steve Breker to Nick Wilkinson

#6 Updated by Nick Wilkinson about 1 year ago

  • Assignee changed from Nick Wilkinson to Sara Allain

Hi Sara, can you please take a look at this for QA?

#7 Updated by Dan Gillean about 1 month ago

  • Assignee deleted (Sara Allain)

#8 Updated by Dan Gillean about 1 month ago

  • Category set to CSV import
  • Status changed from QA/Review to Verified

Also available in: Atom PDF