Feature #12140

Include creator name as an option in the Advanced search panel's field drop-down

Added by Dan Gillean about 1 year ago. Updated about 1 hour ago.

Status:VerifiedStart date:04/13/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:Search / Browse
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.4, 2.5
Sponsored:No Requires documentation:

Description

It has recently been pointed out in the User Forum that the Advanced search panel lacks an option to limit a search string to the creator.

However, this data is indexed, as evidenced by the Creators facet in the left-hand context menu, and the ability to target the creators field directly:

creators.i18n.%LANG%.authorizedFormOfName

For example, to search for John Smith against the creator field in an English interface, you could enter:

creators.i18n.en.authorizedFormOfName:"John Smith" 

This feature request would add Creator name as an option in the AtoM search field delimiters available in the Advanced search panel dropdown.

History

#1 Updated by Nick Wilkinson 12 months ago

  • Assignee set to Mike Cantelon

#2 Updated by Mike Cantelon 12 months ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#3 Updated by Nick Wilkinson 12 months ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#4 Updated by José Raddaoui Marín 12 months ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Changes look great, but I wonder if this should be querying over the inherited creators too. We may need to wait for Dan to get back.

#5 Updated by Dan Gillean 12 months ago

  • Assignee changed from Dan Gillean to Mike Cantelon

Hi! Yes, I think if it doesn't add a lot of time and complexity to this, then it makes sense to return inherited creators as well.

#6 Updated by Mike Cantelon 12 months ago

I think it might be doing that... like, if a top-level description has the creator "Rick" then a creator search for "Rick" will bring both the top level description and its child. Is that the desired behaviour?

#7 Updated by Mike Cantelon 12 months ago

  • Assignee changed from Mike Cantelon to Dan Gillean

#8 Updated by Dan Gillean 12 months ago

  • Project changed from AtoM Wishlist to Access to Memory (AtoM)
  • Category set to Search / Browse
  • Assignee changed from Dan Gillean to Mike Cantelon
  • Target version set to Release 2.5.0
  • Requires documentation set to Yes

Yup, it is! Great, thanks Mike. If that's the case, I guess you can merge this into qa/2.5.x for testing? Going to move this ticket over to the main AtoM project then.

#9 Updated by Mike Cantelon 12 months ago

I tested it and my memory is flawed... it's not picking up inherited creators. I've marked the pull request "work in progress" for now, until I figure out how to do this.

#10 Updated by José Raddaoui Marín 12 months ago

Hi Mike,

In ES the IO documents have `creators` or `inheritedCreators`, never both. The two are foreign types (actor) and have the same fields, so a `BoolQuery` with two `should` over the i18n auth. form of name of both fields should do the trick.

#11 Updated by Mike Cantelon 12 months ago

Thanks Radda... I'll add that.

#12 Updated by Mike Cantelon 12 months ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to José Raddaoui Marín

I've updated the PR to include inheritedCreator values. Let me know if any tweaks should be made.

#13 Updated by José Raddaoui Marín 12 months ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#14 Updated by Mike Cantelon 12 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Thanks Radda... merged to qa/2.5.x for QA.

#15 Updated by Dan Gillean 11 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

Looks good! Thanks!

#16 Updated by Dan Gillean about 1 hour ago

  • Requires documentation deleted (Yes)

Also available in: Atom PDF