Bug #12167

Deletions and/or edits to display labels on login, logout, and myProfile menu nodes have no effect

Added by Dan Gillean about 4 years ago. Updated almost 4 years ago.

Status:VerifiedStart date:04/25/2018
Priority:MediumDue date:
Assignee:Nick Wilkinson% Done:

0%

Category:Menu / navigation
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.4, 2.5
Sponsored:No Requires documentation:

Description

  • Log in as an administrator
  • Navigate to Admin > Menus, and find the elements under quicklinks - login, logout, and myProfile
  • Try changing the Label names, and save - no effect
  • Now return and try deleting these menu nodes
Resulting error
  • Menu labels are not updated
  • Login/out button elements cannot be removed or modified via the menus module
Expected result
  • Users should be able to modify the display labels for these elements
  • A separate option to hide the login menu should be available
  • If these changes are not possible then these elements should either be locked, or removed/hidden from the Menu module

edit-logout-myProfile.png - Editing the logout and My profile labels - works! (16 KB) Dan Gillean, 07/12/2018 09:16 AM

edit-login-button.png - Editing the login button label - works! (17.9 KB) Dan Gillean, 07/12/2018 09:16 AM

deleting-myProfile.png - Deleting the My profile node - breaks everything! (32.6 KB) Dan Gillean, 07/12/2018 09:16 AM

Related issues

Related to Access to Memory (AtoM) - Feature #12168: Add option to hide login button to Admin options Verified 04/25/2018
Related to Access to Memory (AtoM) - Task #11186: Allow key menu item names to be locked Verified 05/23/2017

History

#1 Updated by Dan Gillean about 4 years ago

  • Related to Feature #12168: Add option to hide login button to Admin options added

#2 Updated by Mike Cantelon about 4 years ago

  • Assignee set to Mike Cantelon

#3 Updated by Mike Cantelon almost 4 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

An option for hiding the login menu is available in Visible Elements / Global.

PR for CR: https://github.com/artefactual/atom/pull/747

#4 Updated by Nick Wilkinson almost 4 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#5 Updated by José Raddaoui Marín almost 4 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#6 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x. Can backport after QA.

#7 Updated by Dan Gillean almost 4 years ago

This is 99% awesome. However, the remaining 1% can potentially be catastrophic, and I'm wondering how hard it would be to prevent it completely.

Editing the display labels for login, logout, and myProfile works perfectly.

HOWEVER: If you try deleting myProfile, it deletes EVERYTHING. Search and browse, login menu, all of the Main menu, all the page content. See the attached screenshot.

Is there a way we can just hide or disable the delete button on Admin > Menus > myProfile, to prevent this?

I don't think people are actually going to try this in most cases, so if it's very complicated, I'm prepared to accept this as is - we can always add a warning to the docs. But for good usability practices, I think it would be wise to just prevent people from potentially messing up their whole AtoM instance.

Let me know what's possible!

#8 Updated by Mike Cantelon almost 4 years ago

Awesome... thanks! I'll look into preventing deletion... seems like there should be a way to prevent that.

#9 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

This PR approaches the issue of preventing the deletion of a menu item in the quickest way. Alternatively we could add a "deleteable" column, like settings has.

PR for CR: https://github.com/artefactual/atom/pull/751

I think doing it the more involved way makes more sense.

#10 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Code Review to In progress
  • Assignee changed from Nick Wilkinson to Mike Cantelon

#11 Updated by Mike Cantelon almost 4 years ago

  • Related to Task #11186: Allow key menu item names to be locked added

#12 Updated by Mike Cantelon almost 4 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

This PR also prevents renaming (#11186) of system menu items:

PR for CR: https://github.com/artefactual/atom/pull/752

#13 Updated by Nick Wilkinson almost 4 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, can you please take a look at this for CR?

#14 Updated by José Raddaoui Marín almost 4 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#15 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Cantelon to José Raddaoui Marín

Hi Radda. I've updated the PR with the recommended change (good thinking). I also realized that I'd forgotten to add some data to the menu YML fixture.

#16 Updated by José Raddaoui Marín almost 4 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#17 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x for QA (re: note number 7). Backporting this would be complicated given it involves a migration.

#18 Updated by Dan Gillean almost 4 years ago

  • Target version set to Release 2.5.0

#19 Updated by Mike Cantelon almost 4 years ago

  • Status changed from QA/Review to In progress
  • Assignee changed from Dan Gillean to Mike Cantelon

Actually, I think I found an issue so re-assigning to myself.

#20 Updated by Mike Cantelon almost 4 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

Fix to my previous PR, check for menu name reuse, and locking down more menus:

PR for CR: https://github.com/artefactual/atom/pull/755

#21 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Code Review to In progress
  • Assignee changed from Nick Wilkinson to Mike Cantelon

Dan and Michelle found a migration-related issue with the earlier PR that was merged so I'll add a fix for that to the PR that was about to go to code review.

#22 Updated by Mike Cantelon almost 4 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

New implementation of menu locking that avoids the tricky migration issue:

PR fo CR: https://github.com/artefactual/atom/pull/756

#23 Updated by Nick Wilkinson almost 4 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, passing to you for CR.

#24 Updated by José Raddaoui Marín almost 4 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Cantelon

#25 Updated by Mike Cantelon almost 4 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

#26 Updated by Mike Cantelon almost 4 years ago

New locking implementation merged into qa/2.5.x for QA.

#27 Updated by Michelle Curran almost 4 years ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Dan Gillean to Nick Wilkinson

Verified in qa/2.5.x.

Also available in: Atom PDF