Bug #12322
Repository names should not appear in actor autocompletes
Status: | Verified | Start date: | 07/12/2018 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Actor | |||
Target version: | Release 2.5.0 | |||
Google Code Legacy ID: | Tested version: | 2.4, 2.5 | ||
Sponsored: | No | Requires documentation: |
Description
Related to the following post in the User forum (2018-07-11) and issue #4324:
To reproduce- Create a new repository record, FOO
- Create a new authority record, also named FOO
- Create a new description, and try to link the FOO authority record
- Navigate to an existing authority record, and try to create a relationship with FOO
- Both FOO the authority record and FOO the repository record appear in authority record drop-downs and autocompletes
- User has no way of distinguishing the repository record from the authority record when names are the same (which is a fairly common use case - for example, it exists in the AtoM demo datA)
- Repository records should not appear in authority record autocompletes
- Both authority records and descriptions have their own way of linking to repository records; these should be used instead
Notes
See #4324 for previous context. It appears in that case, the solution was just to resolve the 404 error
This is likely occurring because in AtoM's data model, a repository is just a special type of actor. Prior to 2.4 there was no other way in the user interface to create a relationship between an actor and a repository. However, in 2.4 a field to link an actor to a repo as its maintainer has been added. Because of this, I think we should no longer display repositories in actor autocompletes, if it's possible to filter them out.
History
#1 Updated by Nick Wilkinson over 3 years ago
- Assignee set to Steve Breker
- Target version set to Release 2.5.0
Hi Steve, can you please look into this?
#2 Updated by Steve Breker over 3 years ago
Code change completed. Ready for CR:
https://github.com/artefactual/atom/pull/796
This issue could leave AtoM installs with repos listed as creators. I don't think this should create any critical issues, and as its discovered, the creators could be updated with the correct actor. I have discussed this with DavidJ and Dan and both feel that this issue is rare enough that it should not require a data cleanup script to be run during the 2.5 migration.
#3 Updated by Steve Breker over 3 years ago
- Status changed from New to Code Review
- Assignee changed from Steve Breker to Nick Wilkinson
#4 Updated by Nick Wilkinson over 3 years ago
- Assignee changed from Nick Wilkinson to Mike Cantelon
Hi Mike, passing this along to you for CR.
#5 Updated by Mike Cantelon over 3 years ago
- Status changed from Code Review to Feedback
- Assignee changed from Mike Cantelon to Steve Breker
Looks good to me!
#6 Updated by Steve Breker over 3 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from Steve Breker to Dan Gillean
Merged to qa/2.5.x.
Ready for QA.
#7 Updated by Dan Gillean over 3 years ago
- Status changed from QA/Review to Verified
- Assignee deleted (
Dan Gillean)
Looks good! Thanks!