Bug #12367

Default LOD "record group" does not use recommended level attribute of recordgrp in EAD exports

Added by Dan Gillean 10 months ago. Updated about 1 month ago.

Status:VerifiedStart date:08/08/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:EAD
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.4, 2.5
Sponsored:No Requires documentation:No

Description

  • Create a new description, and give it a level of description of "Record group" (a default level term included in new AtoM installations)
  • Add a lower-level record, also with Record group for LOD. Save.
  • Export the record as EAD 2002 XML

Resulting error

At both the parent level (using the archdesc element) and child levels (using the c element), the level attribute in the EAD XML export is given as in the following example:

<archdesc otherlevel="record group" level="otherlevel" relatedencoding="ISAD(G)v2">

Expected result

EAD 2002 defines a recommended controlled vocabulary of terms to be used. otherlevel should only be used when there is no appropriate match. When "Record group" is used as a level in AtoM, it should export using level="recordgrp" in either archdesc or c elements, as appropriate.

See:

Level in the general attributes: https://www.loc.gov/ead/tglib/att_gen.html

LEVEL -- The hierarchical level of the materials being described by the element. This attribute is available in <archdesc>, where the highest level of material represented in the finding aid must be declared (e.g., collection, fonds, record group), and in <c> and <c01-12> (e.g., subgroup, series, file). If none of the values in the semi-closed list are appropriate, the value "otherlevel" may be chosen and the term specified in the OTHERLEVEL attribute. Values are:

  • collection
  • fonds
  • class
  • recordgrp
  • series
  • subfonds
  • subgrp
  • subseries
  • file
  • item
  • otherlevel

See also:

Note that we would also need to double-check that importing EAD XML descriptions with @level="recordgrp" will also properly map to the Record group default LOD term in AtoM.

History

#1 Updated by Mike Cantelon 4 months ago

I don't get "Record group" as a level of description when I create a new installation with the qa/2.5.x branch. Record group doesn't seem to exist, as installed data, in our codebase.

ubuntu@ubuntu-xenial:/usr/share/nginx/atom$ grep -r -i "Record Group" *
lib/task/pdf/ead-pdf-inventory-summary.xsl:                <!--Creates a submenu for collections, record groups and series and fonds-->
lib/task/pdf/ead-pdf-inventory-summary.xsl:                    <!--Creates a submenu for collections, record groups and series and fonds-->
lib/task/pdf/ead-pdf-inventory-summary.xsl:                    <xsl:when test="../@level='recordgrp'">Record group <xsl:value-of select="ead:unitid"/>: </xsl:when>
lib/task/pdf/ead-pdf-full-details.xsl:                <xsl:when test="../@level='recordgrp'">Record group: </xsl:when>
plugins/sfEadPlugin/lib/sfEadPlugin.class.php:      'recordgrp' => array('record-group', 'record group', 'recordgroup'),

#2 Updated by Dan Gillean 4 months ago

Oh wow, you're right! No wonder. I did a purge, and the only terms added by default were:

  • Collection
  • Fonds
  • Subfonds
  • Series
  • Subseries
  • File
  • Item
  • Part

Mike - if we wanted to, would it be difficult to add this as a default LOD in the future, so we can address this issue?

#3 Updated by Mike Cantelon 4 months ago

Seems like it should be easy to add a new LOD.

#4 Updated by Mike Cantelon 4 months ago

  • Assignee set to Mike Cantelon

#5 Updated by Mike Cantelon 4 months ago

  • Status changed from New to Code Review
  • Assignee deleted (Mike Cantelon)

#6 Updated by Mike Cantelon 4 months ago

  • Assignee set to Steve Breker

I've updated the PR with your recommendation.

#7 Updated by Mike Cantelon 4 months ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Steve Breker to Dan Gillean

Merged into qa/2.5.x. Thanks Steve!

#8 Updated by Mike Cantelon 4 months ago

  • Status changed from QA/Review to Code Review
  • Assignee changed from Dan Gillean to Steve Breker

#9 Updated by Steve Breker 4 months ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Steve Breker to Mike Cantelon

CR complete - Looks good!

#10 Updated by Mike Cantelon 4 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

#11 Updated by Dan Gillean 2 months ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

Hi Mike,

Changes in the EAD export look good - however, I've realized that we didn't update the import code to understand this level and connect it to the new default term, so on re-import, the level comes in as "recordgrp" rather than linking to the term. If it's not going to be a huge amount of time to address this, can you look into this? Thanks!

#12 Updated by Mike Cantelon 2 months ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#13 Updated by Mike Cantelon 2 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Dan Gillean

#14 Updated by Dan Gillean about 1 month ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Target version set to Release 2.5.0
  • Requires documentation set to No

Also available in: Atom PDF