Bug #12429

phing i18n-cleanup halts with error if any plugins don't have an i18n subdirectory

Added by Mike Cantelon 12 months ago. Updated 11 months ago.

Status:VerifiedStart date:09/09/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:I18N
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

The build task

i18n-cleanup
, ran when
phing i18n-pull-translations
is run, halts with error if any plugins don't have an i18n subdirectory.

History

#1 Updated by Mike Cantelon 12 months ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#2 Updated by Mike Cantelon 12 months ago

"halts with error if any plugins don't have an i18n subdirectory, but have translations available" rather.

#3 Updated by Nick Wilkinson 12 months ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

HI Radda, passing to you for CR.

#4 Updated by Mike Cantelon 11 months ago

  • Status changed from Code Review to QA/Review

Thanks Radda!

Merged into qa/2.5.x.

Could you QA this too, if you have time, to make sure I didn't break anything?

#5 Updated by José Raddaoui Marín 11 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (José Raddaoui Marín)

Hi Mike,

I have been working lately with the Docker Compose environment so this was not easy to test. I have been able to run the pull task outside the container but it was failing in the update fixtures sub-task. Removing that sub-task, I have been able to pull without a problem and I saw the "i18n" directories being created and deleted inside the plugins. Looking at your "tx pull" PR it looks like the fixtures issue didn't happen on your end, so I guess that is due to not having a full install locally.

#6 Updated by José Raddaoui Marín 11 months ago

  • Status changed from Verified to Feedback
  • Assignee set to Mike Cantelon

Actually, I don't know if we'll do a Transifex pull before the 2.4.1 release or if this would be an issue in there, but if both things are true, we should cherry-pick to stable/2.4.x.

#8 Updated by José Raddaoui Marín 11 months ago

  • Status changed from Feedback to Verified

Looks like it's not needed for 2.4.1.

#9 Updated by Mike Cantelon 11 months ago

  • Assignee changed from Mike Cantelon to José Raddaoui Marín

Looking at your "tx pull" PR it looks like the fixtures issue didn't happen on your end, so I guess that is due to not having a full install locally.

Hi Radda,

Does this means there's a separate, Docker-related issue we should deal with or is that related to this issue?

#10 Updated by José Raddaoui Marín 11 months ago

  • Assignee deleted (José Raddaoui Marín)

No, it's just that I don't have a full installation locally and I was running the pull task outside the Docker image. We shouldn't care about running this task inside the image as it will require some Python dependencies and Pearl channels only for it. But, if you change the workflow in the move to Weblate, it would be great if you find a PHP way to do it inside the image.

#11 Updated by Mike Cantelon 11 months ago

Ah, good to know! I'll try to make any migration scripts that need to be run with Weblate PHP to avoid additional dependencies.

Also available in: Atom PDF