Bug #12532
Improve csv:import CLI task performance
Status: | Verified | Start date: | 10/25/2018 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | Dan Gillean | % Done: | 0% | |
Category: | CLI tools | |||
Target version: | Release 2.5.0 | |||
Google Code Legacy ID: | Tested version: | 2.5 | ||
Sponsored: | No | Requires documentation: |
Description
The CSV import CLI task is currently disregarding the --index flag when creating notes, events and relations. It is also using a Propel ORM query to check if a note already exists. Both of these issues are causing performance issues particularly when there are a large number of notes contained in a CSV row.
The performance of CSV import can be increased by making the following changes:
- ensure the creation of notes, events and relations respect the --index option.
- replace the notes table Propel query with a PDO query.
History
#3 Updated by Steve Breker over 3 years ago
- Status changed from New to Code Review
- Assignee changed from Steve Breker to Nick Wilkinson
Ready for code review: https://github.com/artefactual/atom/pull/794
#4 Updated by Nick Wilkinson over 3 years ago
- Assignee changed from Nick Wilkinson to Mike Cantelon
Hi Mike, passing to you for CR.
#5 Updated by Mike Cantelon over 3 years ago
- Status changed from Code Review to Feedback
- Assignee changed from Mike Cantelon to Steve Breker
Hi Steve... looks good to me!
#6 Updated by Steve Breker over 3 years ago
- Status changed from Feedback to QA/Review
#8 Updated by Steve Breker over 3 years ago
- Assignee changed from Steve Breker to Dan Gillean
#9 Updated by Dan Gillean about 3 years ago
- Status changed from QA/Review to Verified