Bug #12645

CSV import will treat 2 physical storage with the same name but different types as the same container

Added by Dan Gillean 8 months ago. Updated 8 months ago.

Status:VerifiedStart date:12/17/2018
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:CSV import
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

When you import physical object data in an archival description CSV import, type isn't factored in when determining whether or not the physical object already exists.

To reproduce

  • Create a new CSV import of descriptions, with physical storage data included
  • In one row, add an object with name "Foo", location "Attic" and type "Box"
  • In another row, add an object with name "Foo", location "Attic" and type "Shelf"
  • Import the CSV
  • Navigate to the physical storage module

Resulting error

  • Both locations are treated as one, and linked together
  • The fact that these objects have different types (Box vs Shelf) is ignored
Expected result
  • Two separate storage locations named "Foo" are created - one with a type "Shelf" and one with type "Box"
  • AtoM's CSV import code should look at all 3 physical storaage fields (name, location, type) when determining matching criteria; otherwise, treat it as a new location

test_physical_objects.csv Magnifier (183 Bytes) Mike Cantelon, 12/21/2018 09:36 AM

History

#1 Updated by Mike Cantelon 8 months ago

Attached CSV for testing.

#3 Updated by Mike Cantelon 8 months ago

  • Status changed from New to Code Review
  • Assignee deleted (Mike Cantelon)

#4 Updated by Mike Cantelon 8 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Dan Gillean

Merged into qa/2.5.x for QA.

#5 Updated by Dan Gillean 8 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Target version set to Release 2.5.0

Also available in: Atom PDF