Access to Memory (AtoM)

I just tried running this in the 18.04 test Vagrant box and got a PHP error:

vagrant$ php symfony physicalobject:delete-unlinked

 Are you sure you'd like to delete all unlinked physical objects?

y

Data before clean-up:
 - 29 physical objects

Detecting unlinked physical objects...
 - 9 physical objects marked for deletion
PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function sfCommandApplicationTask::log(), 0 passed in /usr/share/nginx/atom/lib/task/physicalobject/physicalObjectDeleteUnlinkedTask.class.php on line 93 and exactly 1 expected in /usr/share/nginx/atom/vendor/symfony/lib/task/sfCommandApplicationTask.class.php:39
Stack trace:
#0 /usr/share/nginx/atom/lib/task/physicalobject/physicalObjectDeleteUnlinkedTask.class.php(93): sfCommandApplicationTask->log()
#1 /usr/share/nginx/atom/vendor/symfony/lib/task/sfBaseTask.class.php(68): physicalObjectDeleteUnlinkedTask->execute(Array, Array)
#2 /usr/share/nginx/atom/vendor/symfony/lib/task/sfTask.class.php(97): sfBaseTask->doRun(Object(sfCommandManager), NULL)
#3 /usr/share/nginx/atom/vendor/symfony/lib/command/sfSymfonyCommandApplication.class.php(76): sfTask->runFromCLI(Object(sfCommandManager), NULL)
#4 /usr/share/nginx/atom/vendor/symfony/lib/command/cli.php(20): sfSymfonyCommandApplication->run()
#5 /usr/share/nginx/atom/symfony(14): include('/usr/share/ngin...')
#6 in /usr/share/nginx/atom/vendor/symfony/lib/task/sfCommandApplicationTask.class.php on line 39

Some note on the expected behavior, for testing:¶

Invoking the task

symfony physicalobject:delete-unlinked

Task help:

Usage:
php symfony physicalobject:delete-unlinked [--application[="..."]] [--env="..."] [--connection="..."] [-v|--verbose] [-f|--force] [-d|--dry-run]

Options:
 --application  The application name (default: 1)
 --env          The environment (default: cli)
 --connection   The connection name (default: propel)
 --verbose      (-v) Verbose (shows details of what's marked for deletion
 --force        (-f) Delete without confirmation
 --dry-run      (-d) Dry run (no database changes)

Description:
 Delete physical objects that aren't linked to descriptions

Example output:

 Are you sure you'd like to delete all unlinked physical objects?
y
Data before clean-up:
 - 16 physical objects

Detecting unlinked physical objects...
 - 2 physical objects marked for deletion

Deleting unlinked physical objects...
 - 2 physical objects deleted

Data after clean-up:
 - 14 physical objects

Example output (force, verbose)

Data before clean-up:
 - 31 physical objects

Detecting unlinked physical objects...
 - 12 physical objects marked for deletion

Deleting unlinked physical objects...
 - Name: 'SA-01', Location: 'Research Room Annex, Section C', Type: 'Filing cabinet'
 - Name: 'SA-004', Location: 'Archives Cold Storage, Aisle 1', Type: 'Map cabinet'
 - Name: 'C-006', Location: 'Archives Holdings, Aisle 2, Shelf D', Type: 'Folder'
 - Name: 'C-008', Location: 'Research Room Annex, Section C', Type: 'Hollinger box'
 - Name: 'C-018', Location: 'Archives Cold Storage, Aisle 4, Shelf D', Type: 'Hollinger box'
 - Name: 'CTCC-01', Location: 'Row 6, Shelf C', Type: 'Hollinger box'
 - Name: 'SA-PH', Location: 'Archives Cold Storage, Photograph Room', Type: 'Shelf'
 - Name: 'CTCC-01', Location: 'Row 6, Shelf C', Type: 'Hollinger box'
 - Name: 'Shelf 001', Location: 'Vault', Type: 'Shelf'
 - Name: 'SomeName', Location: 'SomeLocation', Type: 'Box'
 - Name: 'SomeName', Location: 'SomeLocation', Type: 'Cardboard box'
 - Name: 'SomeName', Location: 'SomeLocation', Type: 'Filing cabinet'
 - 12 physical objects deleted

Data after clean-up:
 - 19 physical objects

PR for CR: https://github.com/artefactual/atom/pull/882

Merged in qa/2.5.x for QA.

Docs were added to 2.5 in: https://github.com/artefactual/atom-docs/pull/87

See: https://www.accesstomemory.org/docs/latest/admin-manual/maintenance/cli-tools/#manage-physical-storage-locations