Bug #12663

Accession save deleting relations triggering indexing of related descriptions

Added by Steve Breker 8 months ago. Updated 6 months ago.

Status:VerifiedStart date:12/21/2018
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Accessions
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:2.5
Sponsored:Yes Requires documentation:No

Description

Any modification to an Accession in the WebUI is triggering related information object records to be re-indexed in ES - the submit logic deletes all the relations and re-creates them on every save regardless of the change and QubitRelation contains code to reindex IOs when the relation is deleted. The bug is here:

https://github.com/artefactual/atom/blob/qa/2.5.x/plugins/qtAccessionPlugin/modules/accession/actions/editAction.class.php#L316-L320

These should be comparing the relation "subjectId" and not "objectId" (objectId contains the accession.id, subjectId contains the info_obj.id) - this comparison will always fail as-is, and so causes the relations to be deleted and re-added every time someone saves a change regardless of which field is updated. This means unnecessarily re-indexing a large number of information objects, terms etc.


Related issues

Related to Access to Memory (AtoM) - Bug #12739: CSV Accession Import CLI task should create keymap record... Verified 01/23/2019

History

#2 Updated by Dan Gillean 6 months ago

  • Status changed from In progress to Verified
  • Assignee changed from Steve Breker to Dan Gillean
  • Sponsored changed from No to Yes
  • Requires documentation set to No

#3 Updated by Dan Gillean 6 months ago

  • Related to Bug #12739: CSV Accession Import CLI task should create keymap records for import matching added

#4 Updated by Dan Gillean 6 months ago

  • Description updated (diff)

Also available in: Atom PDF