Bug #12695

Full treeview paging-related buttons being display when they shouldn't be

Added by Mike Cantelon 4 months ago. Updated about 1 month ago.

Status:VerifiedStart date:01/09/2019
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Treeview
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Full treeview paging-related buttons (reset and more buttons) are being displayed on description detail pages. Use CSS to fix this.

button-block-public-users.png (38.1 KB) Dan Gillean, 01/29/2019 01:39 PM

History

#2 Updated by Mike Cantelon 4 months ago

  • Status changed from New to Code Review
  • Assignee deleted (Mike Cantelon)

#4 Updated by Steve Breker 4 months ago

  • Status changed from Code Review to Feedback
  • Assignee set to Mike Cantelon

CR complete. LGTM!

#5 Updated by Mike Cantelon 4 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Thanks Steve! Merged into qa/2.5.x.

#6 Updated by Dan Gillean 4 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Target version set to Release 2.5.0

LGTM, can't seem to reproduce what Steve was seeing any more!

#7 Updated by Dan Gillean 4 months ago

Might have found a regression caused by this fix. See attached image.

Essentially, public users can now see the button block placeholder.

Steve also noted the following:

I've also noticed that we need to re-make the arDominion CSS and commit that (or something similar). I still see his buttons once in awhile with the sidebar treeview.

#8 Updated by Mike Cantelon 3 months ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#9 Updated by Dan Gillean 3 months ago

  • Assignee set to Steve Breker

#10 Updated by Steve Breker 3 months ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Steve Breker to Mike Cantelon

Code review complete - looks good!

#11 Updated by Mike Cantelon 3 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x.

#12 Updated by Dan Gillean about 1 month ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF