Bug #12695
Full treeview paging-related buttons being display when they shouldn't be
| Status: | Verified | Start date: | 01/09/2019 | |
|---|---|---|---|---|
| Priority: | Medium | Due date: | ||
| Assignee: | Dan Gillean | % Done: | 0% | |
| Category: | Treeview | |||
| Target version: | Release 2.5.0 | |||
| Google Code Legacy ID: | Tested version: | |||
| Sponsored: | No | Requires documentation: |
Description
Full treeview paging-related buttons (reset and more buttons) are being displayed on description detail pages. Use CSS to fix this.
History
#1 Updated by Mike Cantelon 7 months ago
PR for CR: https://github.com/artefactual/atom/pull/820
#2 Updated by Mike Cantelon 7 months ago
- Status changed from New to Code Review
- Assignee deleted (
Mike Cantelon)
#4 Updated by Steve Breker 7 months ago
- Status changed from Code Review to Feedback
- Assignee set to Mike Cantelon
CR complete. LGTM!
#5 Updated by Mike Cantelon 7 months ago
- Status changed from Feedback to QA/Review
- Assignee changed from Mike Cantelon to Dan Gillean
Thanks Steve! Merged into qa/2.5.x.
#6 Updated by Dan Gillean 7 months ago
- Status changed from QA/Review to Verified
- Assignee deleted (
Dan Gillean) - Target version set to Release 2.5.0
LGTM, can't seem to reproduce what Steve was seeing any more!
#7 Updated by Dan Gillean 7 months ago
- File button-block-public-users.png added
- Status changed from Verified to Feedback
- Assignee set to Mike Cantelon
Might have found a regression caused by this fix. See attached image.
Essentially, public users can now see the button block placeholder.
Steve also noted the following:
I've also noticed that we need to re-make the arDominion CSS and commit that (or something similar). I still see his buttons once in awhile with the sidebar treeview.
#8 Updated by Mike Cantelon 6 months ago
- Status changed from Feedback to Code Review
- Assignee deleted (
Mike Cantelon)
PR for CR: https://github.com/artefactual/atom/pull/843
#9 Updated by Dan Gillean 6 months ago
- Assignee set to Steve Breker
#10 Updated by Steve Breker 6 months ago
- Status changed from Code Review to Feedback
- Assignee changed from Steve Breker to Mike Cantelon
Code review complete - looks good!
#11 Updated by Mike Cantelon 6 months ago
- Status changed from Feedback to QA/Review
- Assignee changed from Mike Cantelon to Dan Gillean
Merged into qa/2.5.x.
#12 Updated by Dan Gillean 5 months ago
- Status changed from QA/Review to Verified