Bug #12721
Avoid config files overwrite in Docker Compose environment
Status: | Verified | Start date: | 01/17/2019 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | José Raddaoui Marín | % Done: | 0% | |
Category: | Docker | |||
Target version: | Release 2.5.0 | |||
Google Code Legacy ID: | Tested version: | 2.4, 2.5 | ||
Sponsored: | No | Requires documentation: |
Description
The config files are regenerated each time the AtoM container is started in https://github.com/artefactual/atom/blob/qa/2.5.x/docker/bootstrap.php#L68-L160.
From the user from thread: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/ica-atom-users/qi7gxz9FNLE/MC4uHDRKCgAJ
History
#1 Updated by José Raddaoui Marín over 3 years ago
- Status changed from New to Code Review
#2 Updated by José Raddaoui Marín over 3 years ago
- Description updated (diff)
#3 Updated by Steve Breker over 3 years ago
- Status changed from Code Review to Feedback
CR complete - Looks great!
#4 Updated by José Raddaoui Marín over 3 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from José Raddaoui Marín to Steve Breker
Thanks Steve! Please, could you also give it a try?
#5 Updated by Steve Breker over 3 years ago
- Status changed from QA/Review to Feedback
- Assignee changed from Steve Breker to José Raddaoui Marín
This works as intended. Modifications to the settings files specified survive and do not not get overwritten.
Since there is no way to detect changes to these files, is there a way to reset them without deleting and re-cloning AtoM if that was desired?
#6 Updated by José Raddaoui Marín over 3 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from José Raddaoui Marín to Steve Breker
You could delete only the config files you want to reset and restart the container. That should add the default versions.
#7 Updated by Steve Breker over 3 years ago
- Assignee changed from Steve Breker to José Raddaoui Marín
I think this should be fine then. This is intended for development use, and a developer should know which files they've modified should they need to reset them I think. You may want to document which files are not overwritten and how to reset them (by deleting them)?
Somewhere here perhaps?
https://www.accesstomemory.org/en/docs/2.5/dev-manual/env/compose/#dev-env-compose
#8 Updated by José Raddaoui Marín about 3 years ago
- Status changed from QA/Review to Verified
Thanks Steve and sorry for the delay on this.
I have added the note to the documentation among other minor changes:
https://github.com/artefactual/atom-docs/pull/57/files
And I've cherry-picked the fix to stable/2.4.x to make the new docs true for both the stable and qa branches:
https://github.com/artefactual/atom/commit/ff347dce2f96cd3a2f0ea59703f35eada9f004a2
Also, I have downgraded the Dockerfile in qa/2.5.x to PHP 7.0 and removed part of the latest changes to make it the same as in the stable/2.4.x branch. Now the only differences between both are the Git branch and the Elasticsearch image:
https://github.com/artefactual/atom/pull/854
I hope this reduces the issues reported in the forum for two different versions, like this one:
Please, feel free to reopen if you think this needs to be revised.