Access to Memory (AtoM)

First reported via a community-filed GitHub issue on the AtoM repo, 2019-01-25:

• https://github.com/artefactual/atom/issues/831

From the report:

Got an error when building a nested set:

PDOException: SQLSTATE[HY000]: General error: trying to execute an empty query in /var/www/html/atom-2.4.1/lib/task/propel/propelBuildNestedSetTask.class.php:126
Stack trace:
#0 /var/www/html/atom-2.4.1/lib/task/propel/propelBuildNestedSetTask.class.php(120): PDO->exec('')

What's happening is the loop at line 117 run's 1 too many times if the row count is a multiple of 4000. We had exactly 84000 records and got the error above. So I think the fix is:

for ($i=0; $i <= (count($this->rows)-1); $i+=$incr)
{
$sql = implode("\n", array_slice($this->rows, $i, $incr));
$conn->exec($sql);
}

Steve has looked at the issue and confirmed its validity.

See: https://github.com/artefactual/atom/blob/qa/2.5.x/lib/task/propel/propelBuildNestedSetTask.class.php#L114-L121