Task #12815

Advanced search refactoring

Added by Mike Cantelon 6 months ago. Updated 5 months ago.

Status:VerifiedStart date:02/13/2019
Priority:LowDue date:
Assignee:-% Done:

0%

Category:Search / Browse
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:No

Description

Use the search filter component created for #12651 in other searches.

Also look at making the empty field sort logic more elegant for #12651.

History

#1 Updated by Mike Cantelon 6 months ago

(Actually looking at making the empty field sort logic more elegant can end up a separate issue.)

#2 Updated by Mike Cantelon 6 months ago

Look at further refactoring by creating an array that defines all filters in the form of 'parameter' => $object.

#3 Updated by Mike Cantelon 6 months ago

Make it so the empty field filter tag and the "has digital object" filter tag can be rendered by components, rather than manually.

#5 Updated by Mike Cantelon 5 months ago

  • Status changed from New to Code Review

#6 Updated by Mike Cantelon 5 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Dan Gillean

Merged into qa/2.5.x.

This basically effects the filter tags for the advanced information object search so that's what should be tested.

#7 Updated by Dan Gillean 5 months ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

The filter tags look good, but we had some validation code in there that was preventing contradictory combinations from being selected in the Top-level and repository filters. You can test to reproduce the lost behavior on the demo site - Pick a repository first. Then pick any random top-level description - you will see that the repository choice will be cleared and the field greyed out so no selection can be made: essentially, you can apply one filter but not both. We should restore this in 2.5.

Also, right now it seems that Genre is the only facet filter that doesn't get a filter tag when a facet is applied.

#8 Updated by Mike Cantelon 5 months ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#9 Updated by José Raddaoui Marín 5 months ago

  • Status changed from Code Review to Feedback
  • Assignee set to Mike Cantelon

#10 Updated by Mike Cantelon 5 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean

Merged into qa/2.5.x for QA.

#11 Updated by Dan Gillean 5 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Target version set to Release 2.5.0
  • Requires documentation set to No

Also available in: Atom PDF