Global search box keyboard navigation not working
|Target version:||Release 2.5.1|
|Google Code Legacy ID:||Tested version:||2.4, 2.5|
- Navigate to any one of the test sites, using Firefox, Chrome, or another modern borser
- Enter "van" into the global search box
- Attempt to use the keyboard down arrow to navigate to one of the autocomplete results
Keyboard navigation not working in Firefox. Tested on Windows 10 with both 18.04 and CentOS VMs, and on Mac OSX using Firefox. Evelyn recently reported that it's not working in Chrome in 2.5.0 either. Seems also not to be working on 2.4.1 public demo site, so this regression was introduced a while ago and we didn't notice - but it did used to work!
Keyboard navigation in the global search box works consistently across browsers.
#1 Updated by Mike Cantelon 12 months ago
Firefox 65 was released on Jan 29 this year (https://www.mozilla.org/en-US/firefox/65.0/releasenotes/) and "As of Firefox 65, the keypress event is no longer fired for non-printable keys" (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent). Will have to modify dominion.js.
#3 Updated by Dan Gillean 12 months ago
Important note from related issue #12725:
There are other deprecated event calls in our JS code as well. From the forum:
Adding to this, there are other deprecations: "keyboardEvent.keyCode" or "keyboardEvent.which", for instance, should be replaced by "keyboardEvent.key" (and those are used in this file as well).
We should review our JS code and update these deprecated event calls.
#7 Updated by Dan Gillean 12 months ago
- Subject changed from Global search box keyboard navigation not working in Firefox to Global search box keyboard navigation not working
- Description updated (diff)
- Assignee deleted (
Updated ticket description and title to reflect the fact that this affects multiple modern browsers - Evelyn reproduced in 2.5.0 using Chrome recently. Please make sure to test across several browsers!