Task #13028

Refactor settings to use new parent class

Added by Mike Cantelon about 3 years ago. Updated almost 2 years ago.

Status:VerifiedStart date:05/14/2019
Priority:LowDue date:
Assignee:-% Done:

0%

Category:Internals
Target version:Release 2.6.0
Google Code Legacy ID: Tested version:
Sponsored:Yes Requires documentation:No

Description

Refactor to reduce code and complexity.

Example refactored settings action: apps/qubit/modules/settings/actions/clipboardAction.class.php

History

#1 Updated by Dan Gillean about 3 years ago

  • Category set to Internals
  • Target version set to Release 2.6.0
  • Sponsored changed from No to Yes
  • Requires documentation set to No

#4 Updated by Mike Cantelon almost 3 years ago

PR for CR (to add checkbox handling to parent class): https://github.com/artefactual/atom/pull/918

#5 Updated by Mike Cantelon almost 3 years ago

  • Status changed from New to Code Review

#6 Updated by Steve Breker almost 3 years ago

  • Status changed from Code Review to Feedback

CR complete. Looks good Mike!

#7 Updated by Mike Cantelon almost 3 years ago

  • Status changed from Feedback to In progress

Thanks Steve!

#9 Updated by Mike Cantelon almost 3 years ago

  • Assignee set to Mike Cantelon

Thanks Steve!

#10 Updated by Mike Cantelon almost 3 years ago

  • Status changed from In progress to Code Review
  • Assignee deleted (Mike Cantelon)

#11 Updated by Mike Cantelon almost 3 years ago

  • Status changed from Code Review to In progress

#12 Updated by Mike Cantelon almost 3 years ago

  • Status changed from In progress to Code Review

#13 Updated by Steve Breker over 2 years ago

  • Status changed from Code Review to Feedback
  • Assignee set to Mike Cantelon

CR complete. Looks good!

#14 Updated by Mike Cantelon over 2 years ago

Thanks Steve!

#15 Updated by Mike Cantelon over 2 years ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#16 Updated by Mike Cantelon over 2 years ago

  • Status changed from Code Review to In progress
  • Assignee set to Mike Cantelon

Thanks Dave!

#17 Updated by Dan Gillean almost 2 years ago

  • Status changed from In progress to Verified
  • Assignee deleted (Mike Cantelon)

Also available in: Atom PDF