Bug #13130

DC XML should include inherited creators at lower levels

Added by Dan Gillean about 1 year ago. Updated 11 months ago.

Status:VerifiedStart date:08/01/2019
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:XML import / export
Target version:Release 2.6.0
Google Code Legacy ID: Tested version:2.4, 2.5
Sponsored:No Requires documentation:

Description

AtoM includes creator inheritance in the user interface, and we encourage users not to link the creator at all levels of description due to this. However, this causes issues for those using DC XML exports, and the OAI-PMH module with DC XML. Since each description is its own DC XML record, AtoM should include the inherited creator on export when generating DC XML.

Note: see also this community-reported issue: https://github.com/artefactual/atom/issues/824

To reproduce

  • Find or create a multi-level description
  • Make sure there is a creator added at the top level of description, and that it is inherited at lower levels
  • Navigate to a lower-level description
  • Run the DC XML export

Resulting error

  • The creator added at the top level of description is not included in the lower-level DC XML record generated on export

Expected result

  • Because each level of description is its own DC XML record, AtoM should include the inherited creator name in the DC XML export.
  • We should make sure this is present in the OAI-PMH responses for DC XML as well

History

#1 Updated by Mike Cantelon about 1 year ago

  • Status changed from New to Code Review

#2 Updated by Mike Cantelon about 1 year ago

  • Assignee set to David Juhasz

I've updated the PR.

#3 Updated by David Juhasz about 1 year ago

  • Assignee changed from David Juhasz to Mike Cantelon

Looks good to me :)

#4 Updated by Mike Cantelon about 1 year ago

  • Status changed from Code Review to QA/Review
  • Assignee deleted (Mike Cantelon)

Merged into qa/2.6.x.

#5 Updated by Dan Gillean about 1 year ago

  • Status changed from QA/Review to Feedback
  • Assignee set to Mike Cantelon
  • Target version set to Release 2.6.0

This seems to be fetching the top-level creator name, rather than checking immediate ancestors to see if there is a different creator.

For example, I tested with this archival unit in the demo data, in qa/2.6.x:

Specifically this record: https://demo.accesstomemory.org/juho-heikki-kantokoski-1988-1957-brother-of-matti-kantokoski

Name of inherited creator: Chisholm, Ann Eva (nee Kantokoski/Koski)
Inherited from: Ann Eva Chisholm (sous-fonds)

To reproduce:
  • Navigate to the Juho record
  • Click the DC XML export

Error encountered
Creator is listed as follows:

<dc:creator>Kantokoski (Koski), Koivula &amp; Korpela Family</dc:creator>

This is the fonds-level creator.

Expected result:

The record should be showing the inherited name from the view page, from the sous-fonds

#6 Updated by Mike Cantelon about 1 year ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#7 Updated by Mike Cantelon 12 months ago

  • Status changed from Code Review to QA/Review

Merged fix into qa/2.6.x.

#8 Updated by Dan Gillean 11 months ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF