Bug #13137

GUI layout gets broken in certain window widths

Added by José Raddaoui Marín 2 months ago. Updated 2 months ago.

Status:VerifiedStart date:08/07/2019
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:CSS/HTML
Target version:Release 2.5.2
Google Code Legacy ID: Tested version:2.0.0, 2.0.1, 2.1, 2.1.1, 2.1.2, 2.2, 2.2.1, 2.3, 2.4, 2.5, 2.6
Sponsored:No Requires documentation:

Description

This can be reproduced in the demo site after you login:

The site header from the arDominionPlugin theme should always wrap its contents instead of having a fixed height to fix this issue.

broken_layout.png (82 KB) José Raddaoui Marín, 08/07/2019 04:47 AM


Related issues

Related to Access to Memory (AtoM) - Bug #6293: Logo larger than 50px in height will break header bar and... New 02/05/2014
Related to Access to Memory (AtoM) - Bug #3895: In the header, site title does not appear correctly when ... New

History

#1 Updated by José Raddaoui Marín 2 months ago

  • Related to Bug #6293: Logo larger than 50px in height will break header bar and page layout added

#2 Updated by José Raddaoui Marín 2 months ago

  • Related to Bug #3895: In the header, site title does not appear correctly when it is very long added

#3 Updated by José Raddaoui Marín 2 months ago

  • Status changed from New to Code Review

I have been able to find a fix for this old issue that will not disrupt the majority (if not all) the theme plugins extending arDominionPlugin:

https://github.com/artefactual/atom/pull/947

It'll also fix the two really old related tickets. There are many things still to improve in the Dominion header, but those improvements will have a lot higher probability of affecting other themes.

#4 Updated by Mike Cantelon 2 months ago

  • Status changed from Code Review to Feedback

Looks good to me... great to have this fixed!

#5 Updated by José Raddaoui Marín 2 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Merged in qa/2.6.x

#6 Updated by Dan Gillean 2 months ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to José Raddaoui Marín

This is great!!! Tested with a 99px height logo, and a really really long site title, at different widths - looks good! Feel free to backport.

#7 Updated by José Raddaoui Marín 2 months ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Awesome! Added to stable/2.5.x

#8 Updated by Dan Gillean 2 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

Also available in: Atom PDF