Bug #13157

Authority record edit page timeouts when multiple descriptions are related to the resource

Added by José Raddaoui Marín 12 months ago. Updated 4 months ago.

Status:VerifiedStart date:08/21/2019
Priority:MediumDue date:
Assignee:-% Done:

100%

Category:Actor
Target version:Release 2.5.4
Google Code Legacy ID: Tested version:2.5, 2.6
Sponsored:No Requires documentation:

Description

The problem seems to happen when all the events related to the actor are loaded in the edit template:

https://github.com/artefactual/atom/blob/qa%2F2.6.x/plugins/sfIsaarPlugin/modules/sfIsaarPlugin/templates/_event.php#L26-L38

We should consider moving this to a different page with pagination or remove it altogether and only allow to edit the event from the related archival description page.

actor-event-pager.png (95.2 KB) Dan Gillean, 11/19/2019 11:09 AM

History

#1 Updated by Mike Cantelon 10 months ago

  • Status changed from New to Code Review

I've added AJAX paging to events on the actor edit page.

In order to do so I made a slight modification to js/multiDelete.js so logic in it can be ran both on page load and when new rows are dynamically added via AJAX (otherwise a delete icon will get added more than once to a row).

I moved JS out of the PHP template file, as well, to make things cleaner.

PR for CR: https://github.com/artefactual/atom/pull/985

#2 Updated by Mike Cantelon 9 months ago

  • Status changed from Code Review to QA/Review

Merged into qa/2.6.x for QA.

#3 Updated by Dan Gillean 9 months ago

  • File actor-event-pager.png added
  • Status changed from QA/Review to Feedback
  • Assignee set to Mike Cantelon
  • Target version set to Release 2.6.0
  • Tested version 2.5, 2.6 added

Some minor feedback:

I almost didn't notice the button at first. I wonder if we can make it say "Show more" instead?

Second, we may want a separate ticket for this, but I think it might be good to apply this to the actor/actor relations widget as well - for consistency at the very least, but also hopefully to avoid issues when there are many actor-actor relations.

Otherwise, it worked well!

Attaching a screenshot showing the functionality, in case we want to use it in the docs later.

#4 Updated by Mike Cantelon 9 months ago

Awesome... I'll change the button text and I'll look at implementing this for actor/actor relations.

#5 Updated by Mike Cantelon 9 months ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#6 Updated by Mike Cantelon 9 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Dan Gillean

Button text change merged into qa/2.6.x.

#7 Updated by Dan Gillean 9 months ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Cantelon

Pager works well. However there is some kind of JS script error where, when you go to create a new authority record, all existing description relations show up in the Relationships area. They are not saved, but we should still address this.

To reproduce

  • Log into an AtoM instance that has data loaded that includes existing authority records with description relations. The demo data works, for example
  • Click Add > Authority record
  • In the edit page, expand the Relationships area

Resulting error

There are existing relations shown in the Relationships area of the edit page on a new authority record

Expected result

The Relationships area should be empty on a new authority record until a user adds relations.

#8 Updated by Mike Cantelon 8 months ago

  • Status changed from Feedback to Code Review
  • Assignee deleted (Mike Cantelon)

#9 Updated by Mike Cantelon 8 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Dan Gillean

Merged into qa/2.6.x to fix the issue specified in note 7.

#10 Updated by Dan Gillean 8 months ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)
  • Requires documentation set to Yes

Looks good.

We should add a note in the docs about this behavior - setting "Requires documentation" to yes so we remember to do this.

#11 Updated by Dan Gillean 5 months ago

  • % Done changed from 0 to 100
  • Requires documentation deleted (Yes)

#12 Updated by Dan Gillean 4 months ago

  • Target version changed from Release 2.6.0 to Release 2.5.4

Also available in: Atom PDF