Authority record edit page timeouts when multiple descriptions are related to the resource
|Assignee:||Dan Gillean||% Done:|
|Target version:||Release 2.6.0|
|Google Code Legacy ID:||Tested version:||2.5, 2.6|
The problem seems to happen when all the events related to the actor are loaded in the edit template:
We should consider moving this to a different page with pagination or remove it altogether and only allow to edit the event from the related archival description page.
#1 Updated by Mike Cantelon about 1 month ago
- Status changed from New to Code Review
I've added AJAX paging to events on the actor edit page.
In order to do so I made a slight modification to js/multiDelete.js so logic in it can be ran both on page load and when new rows are dynamically added via AJAX (otherwise a delete icon will get added more than once to a row).
I moved JS out of the PHP template file, as well, to make things cleaner.
PR for CR: https://github.com/artefactual/atom/pull/985
#3 Updated by Dan Gillean 3 days ago
- File actor-event-pager.png added
- Status changed from QA/Review to Feedback
- Assignee set to Mike Cantelon
- Target version set to Release 2.6.0
- Tested version 2.5, 2.6 added
Some minor feedback:
I almost didn't notice the button at first. I wonder if we can make it say "Show more" instead?
Second, we may want a separate ticket for this, but I think it might be good to apply this to the actor/actor relations widget as well - for consistency at the very least, but also hopefully to avoid issues when there are many actor-actor relations.
Otherwise, it worked well!
Attaching a screenshot showing the functionality, in case we want to use it in the docs later.