Bug #13173
If identifiers contain syntax that conforms to markdown syntax, the identifier is rendered in markdown
Status: | Verified | Start date: | 09/12/2019 | |
---|---|---|---|---|
Priority: | Medium | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Formatting | |||
Target version: | Release 2.6.0 | |||
Google Code Legacy ID: | Tested version: | |||
Sponsored: | No | Requires documentation: |
Description
Example: add RTF001_#_1/67_# to the Identifier field in an archival description.
Desired behaviour: identifier is saved as RTF001_#_1/67_#
Observed behaviour: markdown renders the portion of the identifier 1/67 as 1/67 (italic)
Solution: remove Identifier and Alternate Identifier fields from fields that render markdown syntax
History
#1 Updated by Mike Cantelon over 2 years ago
- Status changed from New to In progress
- Assignee set to Mike Cantelon
#2 Updated by Mike Cantelon over 2 years ago
- Status changed from In progress to Code Review
- Assignee deleted (
Mike Cantelon)
PR for CR: https://github.com/artefactual/atom/pull/972
#3 Updated by Mike Cantelon over 2 years ago
- Status changed from Code Review to QA/Review
Merged into qa/2.6.x.
#4 Updated by Mike Cantelon over 2 years ago
- Status changed from QA/Review to Code Review
PR for CR: https://github.com/artefactual/atom/pull/981
#5 Updated by Mike Cantelon over 2 years ago
- Status changed from Code Review to QA/Review
Merged into qa/2.6.x. Thanks for CR Radda!
#6 Updated by Dan Gillean over 2 years ago
- Category set to Formatting
- Status changed from QA/Review to Feedback
- Assignee set to Mike Cantelon
Works on description view pages, but:
Still seeing identifiers w markdown rendered in:
- search/browse result stubs
- both the full-width treeview and sidebar treeview
- the hierarchy browser
- autocomplete fields (such as the related descriptions dropdown in IO edit pages; the related resources autocomplete in the Relationships area widget; related resouce autocomplete in relationships widget on Functions, etc.)
Also seeing markdown rendering on:
- Accession numbers
- Authority record identifier
- Repository identifier
- Function classification (not sure if we want to implement that one or not)
Similarly, description and institution identifier fields are still rendering markdown across many templates - not sure if we want to include those or not. Personally, I would say that the accession/authority record/repository/description identifier fields, and the places where those are shown (search/browse results and autocompletes, mainly) are the priority
#7 Updated by Mike Cantelon over 2 years ago
(Started rough work on dev/issue-13173-identifier-no-markdown-v2 branch)
#8 Updated by Mike Cantelon over 2 years ago
- Status changed from Feedback to Code Review
- Assignee deleted (
Mike Cantelon)
#9 Updated by Mike Cantelon over 2 years ago
- Status changed from Code Review to QA/Review
Merged into qa/2.6.x.
#10 Updated by Dan Gillean over 2 years ago
- Status changed from QA/Review to Feedback
- Assignee set to Mike Cantelon
Missed authority record view and browse pages.
#11 Updated by Mike Cantelon over 2 years ago
Thanks Dan... I'll fix.
#12 Updated by Mike Cantelon over 2 years ago
- Status changed from Feedback to Code Review
- Assignee deleted (
Mike Cantelon)
#13 Updated by Mike Cantelon over 2 years ago
- Status changed from Code Review to QA/Review
Merged into qa/2.6.x.
#14 Updated by Dan Gillean over 2 years ago
- Status changed from QA/Review to Verified