Bug #13289

Hierarchy browser Reset button missing if treeview pager limit not reached

Added by Dan Gillean about 2 years ago. Updated about 2 years ago.

Status:VerifiedStart date:04/13/2020
Priority:MediumDue date:
Assignee:-% Done:

100%

Category:Treeview
Target version:Release 2.5.4
Google Code Legacy ID: Tested version:
Sponsored:Yes Requires documentation:

Description

In feature #11955 we added the hierarchy browser to AtoM - a full-width treeview that can be enabled by an administrator to browse the archival description holdings of an AtoM installation using a hierarchical treeview.

To help performance, a limit to the number of records loaded at once was added - typically limited to 50 records per load. If more records were available, then a count of remaining top-level descriptions is provided with the option to load more, as well as a "Reset" button, which will collapse all expanded nodes and return the hierarchy browser to its initial state. However, if initial load limit is never reached (for example, if there are only 40 top-level descriptions in an installation), then none of the buttons appear - including the "Reset button.

The "Reset" button is useful even when the initial load is never reached, since it allows a user to quickly collapse all expanded hierarchy browser nodes. This issue ticket will address that bug, ensuring that the "Reset" button is present regardless of whether the pager limit is reached or not.

To reproduce

  • Visit an AtoM site with less than 50 top level descriptions, and make sure the hierarchy browser is enabled via Admin > Settings > Treeview
  • Navigate to Browse > Archival descriptions and click on the Browse hierarchy button at the top of the results

Resulting error

No Reset button is available

Expected result

The reset button should be available on the hierarchy browser page regardless of the number of records present.


Related issues

Related to Access to Memory (AtoM) - Bug #13294: Browse hierarchy more button disappears after expanding n... Verified 04/24/2020

History

#1 Updated by José Raddaoui Marín about 2 years ago

  • Status changed from New to Code Review
  • Assignee deleted (José Raddaoui Marín)

#2 Updated by Steve Breker about 2 years ago

  • Status changed from Code Review to Feedback

CR looks good - Approved

#3 Updated by José Raddaoui Marín about 2 years ago

  • Category set to Treeview
  • Status changed from Feedback to QA/Review
  • Assignee set to Dan Gillean

Thanks Steve! Merged in qa/2.6.x.

#4 Updated by José Raddaoui Marín about 2 years ago

  • Target version changed from Release 2.6.0 to Release 2.5.4

Partially cherry picked to stable/2.5.x.

The qa/2.6.x fix also includes a change to consider the items per page limit in the hierarchy browse page.

#5 Updated by Dan Gillean about 2 years ago

  • Status changed from QA/Review to Verified

#6 Updated by Dan Gillean about 2 years ago

  • Related to Bug #13294: Browse hierarchy more button disappears after expanding nodes added

#7 Updated by Dan Gillean about 2 years ago

  • Assignee deleted (Dan Gillean)
  • % Done changed from 0 to 100

The final functionality, compared to the current behavior, is such a minor change, and there are differences between the 2.6 and 2.5.4 functionality - so in the end, I've decided to leave this as is in the 2.5 documentation, and update the 2.6 documentation instead. In 2.5.4, the only real difference is that the reset button is not displaying in the screenshots, which should be fine for one point release out of 4 in 2.5, especially with 2.6 arriving soon.

Changes added to 2.6 docs in https://github.com/artefactual/atom-docs/commit/56ed038acf79fc22d41e6a23830572fd1e091306

Also available in: Atom PDF