Bug #13294

Browse hierarchy more button disappears after expanding nodes

Added by José Raddaoui Marín about 2 years ago. Updated about 2 years ago.

Status:VerifiedStart date:04/24/2020
Priority:MediumDue date:
Assignee:-% Done:

100%

Category:Treeview
Target version:Release 2.5.4
Google Code Legacy ID: Tested version:2.5, 2.6
Sponsored:No Requires documentation:

Description

To reproduce:

- Visit the browse hierarchy page (enable it in settings/treeview).
- Make sure the more button is in there.
- Expand a node.
- Click the more or the reset button.

The full width tree-view implementation in the browse hierarchy page assigns the node's children count as the total when a node is expanded. This total is then considered to determine the need of the more button.

https://github.com/artefactual/atom/blob/qa/2.6.x/js/hierarchy.js#L75


Related issues

Related to Access to Memory (AtoM) - Bug #13289: Hierarchy browser Reset button missing if treeview pager ... Verified 04/13/2020

History

#1 Updated by José Raddaoui Marín about 2 years ago

  • Description updated (diff)

#2 Updated by José Raddaoui Marín about 2 years ago

  • Status changed from New to Code Review

PR with workaround until we fully solve the full width tree-view pagination:

https://github.com/artefactual/atom/pull/1080

#3 Updated by Steve Breker about 2 years ago

  • Status changed from Code Review to Feedback

CR complete - looks good!

#4 Updated by José Raddaoui Marín about 2 years ago

Thanks Steve, we'll wait in the end to see if this is really needed.

#5 Updated by José Raddaoui Marín about 2 years ago

  • Status changed from Feedback to QA/Review
  • Assignee set to Dan Gillean
  • Target version set to Release 2.5.4

Merged in qa/2.6.x and stable/2.5.x.

#6 Updated by Dan Gillean about 2 years ago

  • Status changed from QA/Review to Verified
  • Requires documentation set to Yes

#7 Updated by Dan Gillean about 2 years ago

  • Related to Bug #13289: Hierarchy browser Reset button missing if treeview pager limit not reached added

#8 Updated by Dan Gillean about 2 years ago

  • Assignee deleted (Dan Gillean)
  • % Done changed from 0 to 100
  • Requires documentation deleted (Yes)

The final functionality, compared to the current behavior, is such a minor change, and there are differences between the 2.6 and 2.5.4 functionality - so in the end, I've decided to leave this as is in the 2.5 documentation, and update the 2.6 documentation instead. In 2.5.4, the only real difference is that the reset button is not displaying in the screenshots, which should be fine for one point release out of 4 in 2.5, especially with 2.6 arriving soon.

Changes added to 2.6 docs in https://github.com/artefactual/atom-docs/commit/56ed038acf79fc22d41e6a23830572fd1e091306

Also available in: Atom PDF