Feature #13332

Feature #13275: Display related authority records on Term view and Taxonomy browse pages

Problem: the "Descriptions" and "Authorities" column headers and tab labels on Term browse pages are not using user interface label settings

Added by Peter Van Garderen 5 months ago. Updated 4 months ago.

Status:VerifiedStart date:05/25/2020
Priority:MediumDue date:
Assignee:Peter Van Garderen% Done:

0%

Category:-
Target version:Release 2.6.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

These are currently hard-coded values using "Descriptions" and "Authorities" on the Term browse columns and "Related Descriptions" and "Related Authorities" on the Term view page. These labels should use the user interface label settings for these entities.

Screen Shot 2020-06-02 at 5.05.31 PM.png (193 KB) Peter Van Garderen, 06/02/2020 08:08 PM

Screen Shot 2020-06-02 at 5.06.01 PM.png (110 KB) Peter Van Garderen, 06/02/2020 08:08 PM

History

#1 Updated by Mike Cantelon 5 months ago

The labels are currently "Descriptions" and "Authorities"... would "Archival description count" (using the UI label for description) and "Authority record count" (using the UI label for actors) work (given the UI labels are singular rather than plural)?

#2 Updated by Peter Van Garderen 5 months ago

Yes, good point about the singular versus plural. I think this is a good solution. Let's run it by @Dan for final sign-off.

#3 Updated by Dan Gillean 5 months ago

I like that solution - I think it's better than creating custom label settings to deal with this.

#4 Updated by Mike Cantelon 5 months ago

  • Status changed from New to Code Review
  • Assignee deleted (Mike Cantelon)

#5 Updated by Mike Cantelon 5 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Peter Van Garderen

Merged into qa/2.6.x.

#6 Updated by Peter Van Garderen 5 months ago

This was fixed for the Term Browse page, e.g. see the first attached screencap where the user interface labels "information objects" and "people and organizations" were used. However, the Term detail page is still using the hard-coded labels "Related Descriptions" and "Related Authorities" (See second screencap). These should also be updated to use the user-interface labels.

#7 Updated by Peter Van Garderen 4 months ago

Actually, we run into same problem here of the user interface labels not being plural. We would want these to read "Related archival descriptions" and "Related authority records" but assuming the user interface labels are singular that wouldn't work. The solution used on the Term browse page doesn't really apply here "Archival description count" and "Authority record count" doesn't seem right. However, it still seems wrong to hard-code these as "Related Descriptions" and "Related Authorities". What to do?

#8 Updated by Peter Van Garderen 4 months ago

After further deliberation we could not come up with any better grammatical option. We decided that sticking with the singular user interface label was still preferred over hard-coding "Related Descriptions" and "Related Authorities" here. Especially since the label will be followed by a count in bracket which makes it more clear that plural values will be displayed under each tab. e.g. Archival description (8) | Authority record (19)

#9 Updated by Mike Cantelon 4 months ago

  • Status changed from In progress to Code Review
  • Assignee deleted (Mike Cantelon)

#10 Updated by Mike Cantelon 4 months ago

  • Status changed from Code Review to QA/Review
  • Assignee set to Peter Van Garderen

Fix merged into qa/2.6.x.

#11 Updated by Peter Van Garderen 4 months ago

  • Status changed from QA/Review to Verified

Fixed.

Also available in: Atom PDF