Task #13518

Allow customization of plugin controllers and views within a theme plugin

Added by José Raddaoui Marín about 1 month ago. Updated 24 days ago.

Status:QA/ReviewStart date:06/01/2021
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

0%

Category:Theming
Target version:Release 2.7.0
Google Code Legacy ID: Tested version:2.0.0, 2.0.1, 2.1, 2.1.1, 2.1.2, 2.2, 2.2.1, 2.3, 2.4, 2.5, 2.6, 2.7
Sponsored:No Requires documentation:Yes

Description

Currently, the AtoM theme plugins like arDominionPlugin and arArchivesCanadaPlugin allow you to overwrite and customize the main application templates and it's module's controllers and views:

https://github.com/artefactual/atom/blob/qa/2.x/plugins/arDominionPlugin/config/arDominionPluginConfiguration.class.php#L43-L49
https://github.com/artefactual/atom/blob/qa/2.x/plugins/arArchivesCanadaPlugin/config/arArchivesCanadaPluginConfiguration.class.php#L43-L49

This creates a fallback mechanism that tries to get the controllers and views from the theme plugin first and then from the main application, but it doesn't work with module's action and templates located in another plugin, like customizing the ISAD template index page:

https://github.com/artefactual/atom/blob/qa/2.x/plugins/sfIsadPlugin/modules/sfIsadPlugin/templates/indexSuccess.php

Ideally, theme plugins should be able to overwrite controllers and views from other plugin modules (with the same fallback mechanism), to reduce changes in the vanilla code when developing a theme/customization.


Related issues

Related to Access to Memory (AtoM) - Bug #13539: Regression - Admin > Groups page no longer accessible via... Verified 07/02/2021

History

#1 Updated by José Raddaoui Marín about 1 month ago

  • Status changed from In progress to Code Review
  • Assignee deleted (José Raddaoui Marín)

#2 Updated by José Raddaoui Marín about 1 month ago

  • Subject changed from Allow customization of plugin templates and actions within a theme plugin to Allow customization of plugin controllers and views within a theme plugin

#3 Updated by José Raddaoui Marín about 1 month ago

  • Status changed from Code Review to QA/Review
  • Assignee set to José Raddaoui Marín

Merged in qa/2.x. We'll test this soon, during theme development.

#4 Updated by José Raddaoui Marín 26 days ago

  • Status changed from QA/Review to Code Review
  • Assignee changed from José Raddaoui Marín to Steve Breker

Found an issue that breaks the qtAclPlugin plugin in some cases ...

https://github.com/artefactual/atom/pull/1335

#5 Updated by José Raddaoui Marín 24 days ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Steve Breker to José Raddaoui Marín

Merged in qa/2.x

#6 Updated by José Raddaoui Marín 23 days ago

  • Related to Bug #13539: Regression - Admin > Groups page no longer accessible via the user interface in 2.7 added

Also available in: Atom PDF