Bug #3987

EAD <unitid> in lower-level descriptions is not complete

Added by David Juhasz almost 11 years ago. Updated over 7 years ago.

Status:VerifiedStart date:
Priority:HighDue date:
Assignee:Dan Gillean% Done:

100%

Category:Import/Export
Target version:Release 2.1.0
Google Code Legacy ID:atom-2039 Tested version:2.0.1
Sponsored:Yes Requires documentation:

Description

To reproduce this error:
1)Export a fonds or collection with lower-level descriptions to EAD-XML

Resulting error:
<unitid> only includes the identifier for the individual archival description

e.g. <unitid encodinganalog="3.1.1">1</unitid>

Expected result:
<unitid> should include the entire unique identifier for the archival description

e.g. <unitid encodinganalog="3.1.1" countrycode="gb" repositorycode="249">OA/1/1</unitid>

[g] Legacy categories: Import/Export, EAD

test-inf-obj.xml Magnifier (6.82 KB) José Raddaoui Marín, 03/19/2013 05:13 PM

test-inf-obj-1.xml Magnifier (6.95 KB) José Raddaoui Marín, 03/19/2013 05:13 PM

test-inf-obj-2.xml Magnifier (6.99 KB) José Raddaoui Marín, 03/19/2013 05:13 PM

test-inf-obj-3.xml Magnifier (7.36 KB) José Raddaoui Marín, 03/19/2013 05:13 PM

test-inf-obj-4.xml Magnifier (7.84 KB) José Raddaoui Marín, 03/19/2013 05:13 PM

History

#1 Updated by David Juhasz almost 11 years ago

[g] New owner: MJ Suhonos

#2 Updated by David Juhasz almost 11 years ago

On 11-08-18 03:57 AM, Victoria Peters wrote:

Ideally, the Hub would like <unitid> to have attributes for the country code and the repository code and then the reference as the value.

So not: <unitid encodinganalog="3.1.1">GB 249 OA/1/1</unitid>

But instead: <unitid encodinganalog="3.1.1" countrycode="gb" repositorycode="249">OA/1/1</unitid>

#3 Updated by MJ Suhonos over 10 years ago

  • Target version changed from Release 1.2 to Release 1.3

Moving to 1.3.

[g] Labels added: Milestone-Release-1.3
[g] Labels removed: Milestone-Release-1.2

#4 Updated by Jesús García Crespo almost 10 years ago

[g] New owner: David Juhasz

#5 Updated by David Juhasz almost 10 years ago

Reassign to new account.

[g] New owner: David Juhasz

#6 Updated by Jessica Bushey over 9 years ago

I tested in 1.3 development. The <unitid> element and what is inside is inconsistently supported. In some cases you can get countrycode included in the unitid element. In other cases it is missing. And then in other cases you have the repositorycode inserted.

#7 Updated by Jessica Bushey over 9 years ago

  • Target version changed from Release 1.3 to Release 2.1.0

[g] Labels added: Milestone-Release-2.0
[g] Labels removed: Milestone-Release-1.3

#8 Updated by Mike Cantelon over 9 years ago

  • Assignee changed from David Juhasz to Mike Cantelon
  • Sponsored set to No

#9 Updated by David Juhasz over 9 years ago

  • Sponsored changed from No to Yes

#10 Updated by Jesús García Crespo over 9 years ago

  • Subject changed from <unitid> in lower-level descriptions is not complete to EAD <unitid> in lower-level descriptions is not complete

#11 Updated by Mike Cantelon over 9 years ago

  • Status changed from New to QA/Review
  • Assignee changed from Mike Cantelon to Jessica Bushey

This should be fixed now.

#12 Updated by David Juhasz over 9 years ago

  • Category set to Import/Export
  • Target version changed from Release 2.1.0 to Release 1.4.0

#13 Updated by Jessica Bushey over 9 years ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Jessica Bushey to Mike Cantelon

EAD now includes the following for a series level description:

<c level="series">
<did><unittitle encodinganalog="3.1.2">Normal Events</unittitle>
<unitid repositorycode="EDM" countrycode="CA" encodinganalog="3.1.1">01</unitid>

This is presented in a bit of a different order than what "The Hub" would like to see. Does order matter?

The information is missing from the file level description, see below:

<c level="file">
<did><unittitle encodinganalog="3.1.2">Paranormal </unittitle>
<unitid encodinganalog="3.1.1">aa</unitid>

Please review the entire issue and respond.

#14 Updated by Mike Cantelon over 9 years ago

  • Assignee changed from Mike Cantelon to José Raddaoui Marín

#15 Updated by Jesús García Crespo about 9 years ago

  • Status changed from Feedback to QA/Review
  • % Done changed from 0 to 100

Applied in changeset atom|commit:9008424e21830cc2cb3b1b64603104f41c8c0613.

#16 Updated by Jessica Bushey about 9 years ago

  • Status changed from QA/Review to Feedback

Please see comment #13. Nothing has changed since then.
Please see comment #2 for accurate representation of the information in EAD.

#17 Updated by Anonymous about 9 years ago

  • Status changed from Feedback to QA/Review

#18 Updated by Jesús García Crespo about 9 years ago

  • Status changed from QA/Review to Feedback

#19 Updated by José Raddaoui Marín about 9 years ago

Hi Jessica,

First of all, I added a new fix, that Jesús has to merge. This fix cleans the repository's value before search it in the next object. Which I think doesn't affect to the problem that you keep finding

But I guess I'm not understanding well the issue. I made this test:

- Create a hierarchy with various levels, without any repository assigned at any level.

- Export to EAD 2002 XML ---> test-inf-obj.xml (Attached).

- Add a repository without country code for the lower level of the hierarchy (File).

- Export to EAD 2002 XML ---> test-inf-obj-1.xml (Attached).

- Remove repository for the lower level, and add it to a higher level (Series).

- Export to EAD 2002 XML ---> test-inf-obj-2.xml (Attached).

- Remove repository for the series level, and add it to the higher level (Fonds).

- Export to EAD 2002 XML ---> test-inf-obj-3.xml (Attached).

- Add country code to the repository.

- Export to EAD 2002 XML ---> test-inf-obj-4.xml (Attached).

I think the order of the attributes is right and lower levels are showing the repository from higher levels when they don't have one assigned.

PD. Sorry for the name of the test objects, :)

#20 Updated by José Raddaoui Marín about 9 years ago

  • Status changed from Feedback to QA/Review

#21 Updated by Jessica Bushey about 9 years ago

Radda- I'm a little confused.When i look at your examples, everything is correct:

<unittitle encodinganalog="3.1.2">test inf obj</unittitle>
<unitid encodinganalog="3.1.1" countrycode="ES" repositorycode="rep_ident" >ident</unitid>

But when I check AtoM dev 1.X and try to export a multi-level description in EAD, I don't see the same encoding. Have you committed the fix?

#22 Updated by Jessica Bushey about 9 years ago

  • Status changed from QA/Review to Feedback

#23 Updated by Jessica Bushey about 9 years ago

  • Status changed from Feedback to Verified

FIX WORKS.

#24 Updated by Dan Gillean about 8 years ago

  • Status changed from Verified to Feedback

This fix does not seem to be working in 2x. If I have a fonds with an ID of 1, a series with an ID of 2, and a file with an ID of 3, AND reference code is set to inherit in Admin > Settings, then in the EAD at the file-level, I should see: <unitid>1-2-3</unitid>. If the reference code is NOT set to inherit, I should only see <unitid>3</unitid> at the file level.

Radda, this issue is marked verfied for 1.4 - did this ever get pushed to 2.x? I tested this on 1.x and did not see it working there either.

#25 Updated by Sarah Romkey over 7 years ago

  • Target version changed from Release 1.4.0 to Release 2.1.0
  • Tested version 2.0.1 added

#26 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Hi Dan, it was fixed the repository stuff, but not the identier/reference code problem. It should be fixed now in qa/1.4.x and qa/2.1.x

#27 Updated by Dan Gillean over 7 years ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to José Raddaoui Marín

Hi Radda,

I'm not sure if this is possible, or if it will affect other things like the full reference code search in Advanced search, but:

For the ref code inheritance, I don't think we should include the country and repository code in the field data if possible, esp. if we are including it as attributes in the unitid element. See David's comments at 2, above.

If we roundtrip as is, then the country and repo code will be duplicated in the display, and then duplicated during re-export.

At this point we are NOT including the country and repo code during search in #6695, advanced search by ref code. I sent it back for this reason, but: if making this change here will complicate 6695, then for 6695 I propose we simply add some kind of help text when the user clicks into the field that indicates that search results will not include country and repo code. I can add suggested language to #6695 if you think that's a solution.

There is a related issue i'm noticing, but I think it's a regression from a different issue. the <eadid> element tags are being escaped during export, but they shouldn't be. Probably a result of the latest attempt to fix #7171. I will post about that there.

#28 Updated by Dan Gillean over 7 years ago

  • Description updated (diff)

[fixed formatting in issue description]

#29 Updated by Dan Gillean over 7 years ago

  • Description updated (diff)

[update issue description to reflect change request in note 2 on this issue ticket]

#30 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Oh, right! It should be fixed now, without the repository data.

#31 Updated by Dan Gillean over 7 years ago

  • Status changed from QA/Review to Verified

Great! Works now.

for users following this ticket: the result of the export is dependent on whether or not you have reference code inheritance turned on or off in Admin > Settings > Global.

In a case where I have the following:

  • Fonds - id=A
  • Series - id=1
  • Item - id=z
  • Refcode separator in Admin > Settings set to use dash
If the reference code inheritance is set to ON, the item level <unitid> will export as:
  • <unitid encodinganalog="3.1.1" countrycode="gb" repositorycode="249">A-1-z</unitid>
If the reference code inheritance is set to OFF, the item level <unitid> will export as:
  • <unitid encodinganalog="3.1.1" countrycode="gb" repositorycode="249">z</unitid>

Also available in: Atom PDF