Bug #4371

Translate note field reveals both languages

Added by Jessica Bushey over 9 years ago. Updated almost 9 years ago.

Status:VerifiedStart date:
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

100%

Category:I18NEstimated time:30.00 hours
Target version:Release 1.4.0
Google Code Legacy ID:atom-2423 Tested version:
Sponsored:No Requires documentation:

Description

To reproduce this error:
  1. Translate RAD notes using translation interface for a record
  2. Note displayed in one language, create new note in a second language
  3. Save

Resulting error:
The note is displayed in both languages

Expected result:
The note is displayed in one language that corresponds with the viewing languages (e.g., French note for French language interface

(Reported by Archeion)

[g] Legacy categories: I18N

French_interface_OtherNotes_Edit.png - When a user has a note entered, no option is given to edit or translate. Attempts to enter a similar note will be understood as new note (27.7 KB) Dan Gillean, 02/13/2013 02:03 PM

French_interface_OtherNotes_result.png - Result of attempting to translate with a new note: both notes will be displayed in all language interfaces. (5.89 KB) Dan Gillean, 02/13/2013 02:03 PM


Related issues

Related to Access to Memory (AtoM) - Bug #4539: Notes disappearance Verified 01/16/2013
Related to Access to Memory (AtoM) - Bug #4411: In Translation mode the original source language is not a... Verified 12/05/2012

History

#1 Updated by David Juhasz over 9 years ago

  • Category set to I18N
  • Assignee changed from David Juhasz to José Raddaoui Marín
  • Target version changed from Release 2.1.0 to Release 1.4.0
  • Sponsored set to No

#2 Updated by Jesús García Crespo over 9 years ago

  • Description updated (diff)

#3 Updated by Jesús García Crespo over 9 years ago

What do you think that they meant by "RAD notes"? Is maybe Archeion referring to the "Other notes" field. Could you reproduce the problem? It would be useful if you can provide a screenshot too, please.

#4 Updated by Dan Gillean over 9 years ago

From testing, it appears that yes, Archeion is referring to the "Other Notes" field in RAD. currently there is no option provided to translate a note, due to the way the Other Notes interface is managed. As such, if a user tries to enter another note (i.e., the same note translated in the same Type of Other Note), it is not understood as a translation, but as an additional note.

The default behaviour around language interfaces in AtoM is that if data is entered in one language that does not have corresponding data in other languages (ie, data entered in the english interface that is not translated in the french template), it will show up in all language views until it is translated. So any field entered in english that is NOT translated into French will still appear in English in the French language interface.

In this case, no option is given to the user to provide an alternate translation, so the note will always appear in whatever language it is entered in originally. Archeion has attempted to choose the same Other Note Type in the French interface and enter a translation, but AtoM interprets this as a new note - consequently both notes will always appear in all language interfaces.

This is a problem with the how Other Notes are managed in the User Interface. We need to review and restructure how this is done so that:
a) users can add more than one note at a time without having to save and re-edit
b) users can edit previous notes instead of having to delete them and update a new note
c) users can translate Other notes

I've attached a few screenshots to help display the behaviour.

#5 Updated by David Juhasz about 9 years ago

  • Estimated time set to 30.00

#6 Updated by David Juhasz about 9 years ago

  • Priority changed from High to Medium

#7 Updated by José Raddaoui Marín about 9 years ago

  • Status changed from New to In progress

#8 Updated by José Raddaoui Marín almost 9 years ago

A few notes before the test:

- I saw that we have the same issue with a lot of note interfaces. So I created a component to use it with all of them. Those notes are:
- RAD: title notes and other notes
- ISAD: publication notes, notes and archivist's notes

- I had to do a few changes in multiRow.js, so maybe other tables using it may be affected (all the tables with "Add new" at the bottom)

- For the traslation of the notes, I had to add a option to the render_field method, to show only the field without wrapper or label, so every field that can be translated may encounter problems (it will be very clear if so)

I hope everything goes right.

#9 Updated by José Raddaoui Marín almost 9 years ago

  • Status changed from In progress to QA/Review
  • % Done changed from 0 to 100

Applied in changeset atom|commit:c7975e5bfb3b5309f7ead49a070cbb46b1d43756

#10 Updated by Dan Gillean almost 9 years ago

  • Status changed from QA/Review to Feedback

If a user creates a record, switches the culture, and adds new data to a notes fields (where previously there was none in the original record/original culture), saves, and then switches back to the original culture, the notes data will show up in the original record, in both the view and edit screens. In a situation where there are multiple translations, this can be especially confusing. So far none of the other fields have displayed this behaviour, so the related issue ticket at #4411 has been closed.

#11 Updated by José Raddaoui Marín almost 9 years ago

  • Status changed from Feedback to QA/Review

Applied in changeset atom|commit:82d281ead5dc02e58e836701857a61c3140b7f45.

#12 Updated by José Raddaoui Marín almost 9 years ago

As David said yesterday in the IRC chat, new notes will have the same source culture than the archival description, even those created in a different culture.

Allow translation to only the notes created in the source culture of the description and avoid empty rows in the edit template was harder than expected, because how render_field method works. So I had to remove those notes from the edit template, but only if we are not in the culture where the note was really created (not source culture, as it will always be the description's source culture).

So, the final result is:

- Only the notes created in the source culture of the archival description can be translated

- The ones created in other culture will only appear in this culture (index and edit templates)

#13 Updated by Dan Gillean almost 9 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF