Bug #4549

Donor location information being overwritten by City Name.

Added by Jessica Bushey over 9 years ago. Updated over 8 years ago.

Status:FeedbackStart date:01/21/2013
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

100%

Category:Form validationEstimated time:16.00 hours
Target version:Release 1.4.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Scenario One:
1) Create Accession1 with donor: "lastname, firstname". Add location information to donor dialog- include street and country. Save.
2) Create Accession2 and select the same donor from the drop-down list. Do not edit donor information. Save. View accession record and the donor information is identical (street and country) to the original donor record. Everything is good.

Scenario Two:
1) Create Accession1 with donor: "lastname, firstname". Add location information to donor dialog- include street and country. Save.
2) Edit donor location information to include a City name. You will see that the original street and country information is in the template when you do this. Save. View the donor record and you can see street, City and country names.
3) Create Accession2 and select donor from the same donor form the drop-down list. Do not edit donor information. Save. View accession record and the donor information only has a City name, the original donor record information (street and country) have been overwritten.
4) View the donor record (via the manage donor records) and you will see that the donor record does not contain the street and country information in any instance, only the city name. The City name has overwritten all location information for the donor in accession1 and accession2.

Expected Results:
You should be able to add a City name to the Donor location information and NOT have it rewrite all existing location information.
You should be able to select a donor name from the drop-down list and have it include all the original location information.

This bug was first reported by CVA.

History

#1 Updated by José Raddaoui Marín about 9 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#2 Updated by Jesús García Crespo almost 9 years ago

  • Status changed from New to QA/Review

#3 Updated by Jesús García Crespo almost 9 years ago

  • % Done changed from 0 to 100

Applied in changeset atom|commit:bed766921773732a32a4d08d658129da2e491230.

#4 Updated by Jesús García Crespo almost 9 years ago

  • Estimated time set to 16.00

#5 Updated by Jessica Bushey almost 9 years ago

  • Status changed from QA/Review to Verified

You can now add the City information (but only through the donor edit template, it is not available through the pop-up template in the accession record) and the street and country information stays the same.

#6 Updated by Dan Gillean over 8 years ago

  • Status changed from Verified to Feedback

Reported as still broken by CVA; tested and reproduced in 2x. When selecting an existing donor from the dropdown, any contact information fields that already exist should POPULATE the donor dialog immediately, so the user can a) see that there is data, b) edit it if they desire, and c) not overwrite the information when saving.

If it's not possible to populate the fields with existing data when a donor name is selected, it should at the very least NOT overwrite existing data if the field is left blank (i.e. ONLY if the user enters new data into a field).

Was this fix ever merged into 2x? That's where I tested, since it was last updated 5 months ago as verified, and I assume we did a merge before the 2.0.0 release - but I haven't tested on 1.x to verify.

Also available in: Atom PDF