Bug #4620

Institutional Edit Theme option headings should be made more distinct

Added by Dan Gillean over 9 years ago. Updated over 8 years ago.

Status:VerifiedStart date:02/04/2013
Priority:LowDue date:
Assignee:José Raddaoui Marín% Done:

100%

Category:CSS/HTMLEstimated time:1.50 hour
Target version:Release 2.0.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

See the attached screenshot - currently the headings for "Background Color,""Banner," "Logo," and "Description" are in the same font-weight as the description help text. They should be bolded/enlarged to better stand out as headings

Bannerheading_EditTheme_page.PNG (6.32 KB) Dan Gillean, 02/04/2013 04:13 PM


Related issues

Related to Access to Memory (AtoM) - Bug #4623: Institutional Edit Theme options are not consistent in po... Verified 02/04/2013
Related to Access to Memory (AtoM) - Bug #4627: Institutional Edit Theme page: Remove Banner/Logo checkbo... Verified 02/04/2013

History

#2 Updated by Jesús García Crespo about 9 years ago

  • Target version changed from Release 2.0 - interim 1 to Release 2.0.0

#3 Updated by Jesús García Crespo almost 9 years ago

  • Estimated time set to 1.50

#4 Updated by Jesús García Crespo over 8 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#5 Updated by José Raddaoui Marín over 8 years ago

  • Status changed from New to QA/Review
  • % Done changed from 0 to 100

Applied in changeset atom|commit:75884494aae539acd0d241cbfd09f3c0a09ba2f9.

#6 Updated by Dan Gillean over 8 years ago

  • Status changed from QA/Review to Feedback

The layout fixes make this a lot better. Is it possible to bold the headings for Background color, Banner, Logo, and Description though? Not a big deal if not; like I said the CSS fixes on the layout make it pretty manageable - but it would be nice to have some visual distinction.

#7 Updated by José Raddaoui Marín over 8 years ago

They were bolded, but I suppose that Sevein has changed it back. It was a provisional fix, I think we should create a style for all the form labels.

#8 Updated by Dan Gillean over 8 years ago

Good to know. what should I do with this issue ticket for now then? Bump to 2.1? Close and file new issue for the style for all labels?

#9 Updated by Jesús García Crespo over 8 years ago

  • Status changed from Feedback to QA/Review

Adding HTML tags in the i18n labels wasn't a good idea. Sorry, I didn't notice that there was an actual issue for this.

I don't think the problem is the weight of the label but in the context where it is. I've tried adding some padding and a different background in commit:e728146f294611 and I think that it works well. Take a look pls.

#10 Updated by Dan Gillean over 8 years ago

  • Status changed from QA/Review to Verified

If it's a problem to add CSS to the labels, don't worry about it. The padding etc help a lot.

Also available in: Atom PDF