Bug #5191

Treeview causes repeated terms on scroll

Added by Dan Gillean almost 9 years ago. Updated over 8 years ago.

Status:VerifiedStart date:06/05/2013
Priority:HighDue date:
Assignee:José Raddaoui Marín% Done:

100%

Category:Taxonomy / TermEstimated time:5.00 hours
Target version:Release 1.4.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Test was performed in 2.x dev environment, but the code base for the treeview is exactly the same

To Reproduce
  • Switch culture of AtoM to French
  • Navigate to a place term in a large nested set (ex: to Alberta in the ArchivesCanada data)
  • Explore term treeview in context menu (i.e. expand other terms, siblings, etc.) until scroll bar appears; scroll down
Resulting error
  • Treeview scrolls endlessly
  • Terms are repeated endlessly

(see attached screeenshot)

taxonomyTreeview.png (188 KB) Dan Gillean, 06/05/2013 04:05 PM

repetition_in_Treeview.png (14.4 KB) Dan Gillean, 07/04/2013 03:06 PM

History

#1 Updated by Dan Gillean almost 9 years ago

  • File repetition_in_Treeview.png added
  • Subject changed from When culture is not English, Taxonomy term treeview causes repeated terms on scroll to Treeview causes repeated terms on scroll
  • Priority changed from Medium to Critical

This has recently been identified in a production instance of an AtoM user, in which the only culture in use has been English, and the problem behaviour was on the archival description context menu treeview - so I have changed the name of the issue ticket to reflect this. I have seen the behaviour myself though it reproduces inconsistently. Fixing it is critical however.

In the case of the context menu treeview, the archival description was a subseries with files. I have attached a screenshot.

#2 Updated by Jesús García Crespo almost 9 years ago

  • Estimated time set to 3.00

#3 Updated by Jesús García Crespo almost 9 years ago

  • Priority changed from Critical to High

#4 Updated by José Raddaoui Marín almost 9 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#5 Updated by Jesús García Crespo almost 9 years ago

  • Estimated time changed from 3.00 to 5.00

#6 Updated by José Raddaoui Marín almost 9 years ago

  • Status changed from New to QA/Review
  • % Done changed from 0 to 100

Applied in changeset atom|commit:bed35cf881ce1b0d56403d6d343194eac5ba7621.

#7 Updated by Dan Gillean almost 9 years ago

Radda, this is great! I'm wondering about how to test this - i need a dataset that is big enough to produce the problem to know if it's fixed. Could this fix be applied as a patch? i.e., would it be possible to apply this to the client repo who reported the problem on their archival description treeview, and see if it fixes it?

Thanks!

#8 Updated by Jesús García Crespo almost 9 years ago

Dan, I can do that for you. Please let me know where do you want to test it, but let's keep these details off of this issue.

#9 Updated by Jesús García Crespo almost 9 years ago

  • Status changed from QA/Review to In progress

Radda, I was able to reproduce the error in the information object treeview.
I used the same data set that Dan was using in the screenshots.
I'll contact you by email with some instructions on how to reproduce.

#10 Updated by José Raddaoui Marín almost 9 years ago

  • Status changed from In progress to QA/Review

Applied in changeset atom|commit:08e4a855628cd73827e3633e23c4156cbf8336c7

#11 Updated by José Raddaoui Marín almost 9 years ago

Finally we had two differents issues here:

  • How we're making the query in cultures different than the source culture, wich was causing the endless trevieew, repeating always the same items.
  • How we're concatenating the identifier and title, wich was causing sometimes a repeated item, in all cultures.

Now both should be fixed.

#12 Updated by Jessica Bushey over 8 years ago

  • Status changed from QA/Review to Verified

I tested in 2.X and everything works (treeview of places and treeview of numerous files).
Should I be testing in 1.X? If so, I'll need some data to dump into the test site.
I also tested in multiple languages.

Also available in: Atom PDF